Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2086163002: Arc++: Fix a regression issue that some Chrome app could not load its icon when login at first time. (Closed)

Created:
4 years, 6 months ago by xdai1
Modified:
4 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Matt Giuca, tfarina, tapted, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Arc++: Fix a regression issue that Chrome app could not load its icon when login at first time. It's a regression issue caused by https://codereview.chromium.org/2067943004. Repro steps: 1. In the login screen add a new user 2. Wait until all chrome apps are loaded. All Chrome apps should have their apps correctly. BUG=b/29547412 Committed: https://crrev.com/86716bea3382dca438a9c156e39d271965cb4bca Cr-Commit-Position: refs/heads/master@{#401142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/app_list/extension_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
xdai1
xiyuan@, could you help review this CL please? Thanks!
4 years, 6 months ago (2016-06-21 22:26:01 UTC) #3
xiyuan
lgtm
4 years, 6 months ago (2016-06-21 22:33:34 UTC) #4
xdai1
On 2016/06/21 22:33:34, xiyuan wrote: > lgtm Thanks for the review!
4 years, 6 months ago (2016-06-21 22:34:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086163002/1
4 years, 6 months ago (2016-06-21 22:36:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 00:00:39 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 00:02:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86716bea3382dca438a9c156e39d271965cb4bca
Cr-Commit-Position: refs/heads/master@{#401142}

Powered by Google App Engine
This is Rietveld 408576698