ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.

Committed: https://crrev.com/622fb32dda21261fd4d8650386fec11822db27b0
Cr-Commit-Position: refs/heads/master@{#400527}

[xdai1, 2016-06-15 00:13:34]

Description was changed from

==========
ARC: Add badge for Chrome Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome Apps if
Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.
==========

to

==========
ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.
==========

[xdai1, 2016-06-15 00:32:27]

Patchset #1 (id:1) has been deleted

[xdai1, 2016-06-15 22:34:28]

xdai@chromium.org changed reviewers:
+ benwells@chromium.org, khmel@chromium.org, oshima@chromium.org,
skuhne@chromium.org

[xdai1, 2016-06-15 22:34:29]

khmel@, skuhne@, oshima@, benwells@, could you help review this CL please?
Thanks!

khmel@: all
skuhne@: ash/shelf/shelf_view.cc and files in chrome/browser/ui/ash/launcher
oshima@: files in ui/chromeos/resources/ and chrome/browser/chromeos
benwells@: files in chrome/browser/ui/app_list and chrome/browser/extensions

[Mr4D (OOO till 08-26), 2016-06-15 23:03:23]

ash/shelf/shelf_view.cc and files in chrome/browser/ui/ash/launcher lgtm

https://codereview.chromium.org/2067943004/diff/60001/chrome/browser/ui/ash/l...
File chrome/browser/ui/ash/launcher/launcher_extension_app_updater.cc (right):

https://codereview.chromium.org/2067943004/diff/60001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/launcher_extension_app_updater.cc:79:
extension_registry_->RemoveObserver(this);
you might do if (!extension_registry_) return; ..

[benwells, 2016-06-16 07:45:43]

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/extensi...
File chrome/browser/extensions/extension_app_icon_loader.cc (right):

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/extensi...
chrome/browser/extensions/extension_app_icon_loader.cc:100:
util::MaybeApplyChromeBadge(profile(), id, &image);
Why do you have to do this here and in all the UI surfaces?

[khmel, 2016-06-16 15:27:59]

lgtm

[xdai1, 2016-06-16 17:00:13]

khmel@, skuhne@, thanks for your review!

benwells@, oshima@, please take another look, thanks!

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/extensi...
File chrome/browser/extensions/extension_app_icon_loader.cc (right):

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/extensi...
chrome/browser/extensions/extension_app_icon_loader.cc:100:
util::MaybeApplyChromeBadge(profile(), id, &image);
On 2016/06/16 07:45:43, benwells wrote:
> Why do you have to do this here and in all the UI surfaces?

From my understanding, this work is mostly for experiment. Depending on the
dogfooders'/users' feedback, this work might be totally reverted in the future
or we might want to badge other Chrome apps from different categories (e.g.,
platform apps, webstore apps, etc) or badge Android apps instead. It might be
easier to implement it from UI level.

[oshima, 2016-06-16 17:55:56]

chromeos lgtm with following nits

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/extensions/gfx_utils.cc (right):

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/gfx_utils.cc:24: gfx::ImageSkia* icon) {
nit: icon_out

https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/extensions/gfx_utils.cc:54: if (badge_image->size() ==
icon->size()) {
if (badge_image->size() != icon->size())
  badge_image = CreateResizeImage()

*icon_out = CreateSuperimposedImage(*icon, badge_image);

[xdai1, 2016-06-16 19:22:27]

Patchset #7 (id:130001) has been deleted

[xdai1, 2016-06-16 20:34:04]

On 2016/06/16 17:55:56, oshima wrote:
> chromeos lgtm with following nits
> 
>
https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
> File chrome/browser/chromeos/extensions/gfx_utils.cc (right):
> 
>
https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
> chrome/browser/chromeos/extensions/gfx_utils.cc:24: gfx::ImageSkia* icon) {
> nit: icon_out
> 
>
https://codereview.chromium.org/2067943004/diff/120001/chrome/browser/chromeo...
> chrome/browser/chromeos/extensions/gfx_utils.cc:54: if (badge_image->size() ==
> icon->size()) {
> if (badge_image->size() != icon->size())
>   badge_image = CreateResizeImage()
> 
> *icon_out = CreateSuperimposedImage(*icon, badge_image);

Addressed! Thanks for your review!

[xdai1, 2016-06-17 16:41:20]

benwells@, kindly ping?

[xdai1, 2016-06-17 20:32:23]

xdai@chromium.org changed reviewers:
+ rockot@chromium.org, xiyuan@chromium.org
- benwells@chromium.org

[xdai1, 2016-06-17 20:32:24]

seems benwells@ is OOO. rockot@, xiyuan@, could you help review this CL please?
Thanks!

rockot@:
chrome/browser/extensions/extension_app_icon_loader.cc

xiyuan@:
files in chrome/browser/ui/app_list

[xiyuan, 2016-06-17 20:57:30]

lgtm

https://codereview.chromium.org/2067943004/diff/150001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h (right):

https://codereview.chromium.org/2067943004/diff/150001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/launcher_extension_app_updater.h:47: void
UpdateHostApp(const std::string& app_id);
nit: to be consistent, HostApp -> HostedApp for all three.

i.e.
  UpdateHostApps -> UpdateHostedApps
  UpdateHostApp -> UpdateHostedApp

[Ken Rockot(use gerrit already), 2016-06-17 20:58:33]

lgtm

[xdai1, 2016-06-17 21:41:15]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2016-06-17 21:41:15]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org,
oshima@chromium.org, khmel@chromium.org, rockot@chromium.org,
xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2067943004/#ps170001
(title: "Address xiyuan@'s comment. Rebase")

[commit-bot: I haz the power, 2016-06-17 21:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067943004/170001

[commit-bot: I haz the power, 2016-06-17 22:27:50]

Description was changed from

==========
ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.
==========

to

==========
ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.
==========

[commit-bot: I haz the power, 2016-06-17 22:27:51]

Committed patchset #8 (id:170001)

[commit-bot: I haz the power, 2016-06-17 22:29:06]

Description was changed from

==========
ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.
==========

to

==========
ARC: Add badge for Chrome hosted Apps if Arc++ is enabled.

In order to distinguish between the Chrome Apps and Anroid Apps that
have the same icons, a special badge icon is added for Chrome hosted Apps
if Arc++ is enabled. Badge appears in shelf, app list and recent apps.
- Badge is only applied on the Chrome host Apps for the primary user.
  If more than one user logs in the system, only the primary user has
  the badge.
- Enable/Disable Arc will instantly turn on/off badges.

The implementation is mostly based on khmel@'s initial CL:
https://codereview.chromium.org/1967663007

BUG=b/28521800
TEST=1. Open chrome://settings, click the checkbox to enable/disable Android
        Apps. Notice the badges on the Chrome apps appear/disappear accordingly.
     2. Log in a second user. Switch between users and notice the badges on
        the Chrome apps appear/disappear accordingly.

Committed: https://crrev.com/622fb32dda21261fd4d8650386fec11822db27b0
Cr-Commit-Position: refs/heads/master@{#400527}
==========

[commit-bot: I haz the power, 2016-06-17 22:29:08]

Patchset 8 (id:??) landed as
https://crrev.com/622fb32dda21261fd4d8650386fec11822db27b0
Cr-Commit-Position: refs/heads/master@{#400527}