Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2086143002: Convert TrayEventFilter to wm common types (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert TrayEventFilter to wm common types * Use WmShell for PointerWatcher access * Remove unused includes of ash/root_window_controller.h * Disallow ash/root_window_controller.h usage in ash/system/tray via DEPS * Remove ContainerDelegate, which is now unused This cannot move to //ash/common yet because it has dependencies on TrayBackgroundView. BUG=619636 TEST=ash_unittests, manual tests that the system tray bubble closes when you click outside it, but does not close if you click on a notification Committed: https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc Cr-Commit-Position: refs/heads/master@{#401188}

Patch Set 1 #

Patch Set 2 : Remove ContainerDelegate #

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -254 lines) Patch
M ash/ash.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M ash/common/wm_shell.h View 2 chunks +7 lines, -0 lines 0 comments Download
D ash/container_delegate.h View 1 1 chunk +0 lines, -29 lines 0 comments Download
D ash/container_delegate_aura.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D ash/container_delegate_aura.cc View 1 1 chunk +0 lines, -37 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 2 chunks +15 lines, -6 lines 0 comments Download
M ash/shell.h View 1 3 chunks +0 lines, -4 lines 0 comments Download
M ash/shell.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M ash/shell_delegate.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
A ash/system/tray/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 2 3 chunks +10 lines, -15 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D ash/sysui/container_delegate_mus.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D ash/sysui/container_delegate_mus.cc View 1 1 chunk +0 lines, -49 lines 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
James Cook
msw, please take a look. (Finally, a CL that removes more than it adds!)
4 years, 6 months ago (2016-06-21 21:30:37 UTC) #3
msw
nice; lgtm
4 years, 6 months ago (2016-06-21 22:38:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086143002/40001
4 years, 6 months ago (2016-06-21 23:20:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/242893)
4 years, 6 months ago (2016-06-22 01:11:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086143002/40001
4 years, 6 months ago (2016-06-22 01:52:07 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-22 03:11:24 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 03:13:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc
Cr-Commit-Position: refs/heads/master@{#401188}

Powered by Google App Engine
This is Rietveld 408576698