Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2085133002: Convert TrayBubbleWrapper to wm common types (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@eventfilter
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert TrayBubbleWrapper to wm common types This can't move to //ash/common yet because of dependencies on TrayBackgroundView. BUG=619636 TEST=manual, see crbug.com/177075 Committed: https://crrev.com/143c7930eae1a0984232e8e306798e20fda4e3c4 Cr-Commit-Position: refs/heads/master@{#401314}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M ash/system/tray/tray_bubble_wrapper.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
James Cook
msw, please take a look. There are some intertwined dependencies between these core ash/system/tray classes. ...
4 years, 6 months ago (2016-06-21 22:56:26 UTC) #2
msw
nice; lgtm
4 years, 6 months ago (2016-06-21 23:07:46 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2086143002 Patch 40001). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-21 23:21:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085133002/20001
4 years, 6 months ago (2016-06-22 15:54:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 17:05:35 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:08:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/143c7930eae1a0984232e8e306798e20fda4e3c4
Cr-Commit-Position: refs/heads/master@{#401314}

Powered by Google App Engine
This is Rietveld 408576698