[Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

appengine/findit/templates/build_failure.html

Index: appengine/findit/templates/build_failure.html
diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html
index aa6bc0438d5d664ecb8caa0905934461a2e4e77a..213c312a85e575999a53e10bd1e5f0b91c8b5b55 100644
--- a/appengine/findit/templates/build_failure.html
+++ b/appengine/findit/templates/build_failure.html
@@ -76,7 +76,9 @@
     findit.analysisFailed = '{{analysis_failed}}' == 'True';
     findit.builderUrl = 'https://build.chromium.org/p/{{master_name}}/builders/{{builder_name}}';
     findit.buildUrl = findit.builderUrl + '/builds/{{build_number}}';
+    findit.triageReferenceAnalysisUrl = '/waterfall/build-failure?url=https://build.chromium.org/p/{{triage_reference_analysis_master_name}}/builders/{{triage_reference_analysis_builder_name}}/builds/{{triage_reference_analysis_build_number}}'

[stgao, 2016/06/30 01:08:16]

Per coding style, JS statement should always end with a ";".

Same for other lines of new code in this CL.

[josiahk, 2016/06/30 22:34:57]

Done!

     findit.analysisCorrect = '{{analysis_correct}}';  // Possible values: 'None', 'True', or 'False'.
+    findit.analysisIsDuplicate = '{{analysis_is_duplicate}}' == 'True';
     findit.showTriageHelpButton = '{{show_triage_help_button}}' == 'True';
     findit.showDebugInfo = '{{show_debug_info}}' == 'True';
     findit.analysisResult = {{analysis_result | tojson | safe}};
@@ -96,6 +98,8 @@
         } else {
           alert('Failed to update datastore. Please refresh and try again.');
         }
+        $('#duplicates_marked').html("Number of matching build analyses that were also triaged: " + data['num_duplicate_analyses'])

[stgao, 2016/06/30 01:08:16]

code style: no double quote ["] in JS code.
Same for new JS code below.

Note: in html code below, we do you double quote instead of single quote for
attribute values.

[josiahk, 2016/06/30 22:34:57]

Done.

+        $('#duplicate_reference').html("")
       }).error(function(xhr) {
         // Replace the whole page with errors from server side.
         document.body.outerHTML = xhr.responseText;
@@ -437,6 +441,12 @@
             $('.thumb-down').addClass('triaged').removeClass('triage');
           }
 
+          if (findit.analysisIsDuplicate) {

[stgao, 2016/06/30 01:08:16]

To double check: do we want to show this to everyone or just to Findit admins?

[josiahk, 2016/06/30 22:34:57]

Changed to show duplicate information only if show_debug_info is true (which
will be true if the user is an admin, or if the &debug=1 flag is present in the
URL)

+            $('#duplicate_reference').html("This analysis was automatically triaged as a duplicate because of another build analysis: " +
+                                           "<a href='" + findit.triageReferenceAnalysisUrl + "'>{{triage_reference_analysis_master_name}}/" +
+                                           "{{triage_reference_analysis_builder_name}}/{{triage_reference_analysis_build_number}}</a>")
+          }
+
           if (findit.showTriageHelpButton) {
             $('#triage_help_button').click(triageHelp);
           }
@@ -647,6 +657,8 @@
           <div class="triage thumb-up">Correct <img src="https://www.gstatic.com/images/icons/material/system/1x/thumb_up_black_24dp.png"/></div>
           <div class="triage thumb-down"><img src="https://www.gstatic.com/images/icons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div>
         </div>
+        <div id="duplicates_marked"></div>
+        <div id="duplicate_reference"></div>
       </div>
     {% endif %}
   {% endif %}