Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: appengine/findit/templates/build_failure.html

Issue 2086113004: [Findit] Show build analysis references in UI for Findit Cross-platform auto-triage (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@build-matching
Patch Set: Merged with build-matching Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/model/wf_analysis.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <head> 2 <head>
3 <title>Build Failure</title> 3 <title>Build Failure</title>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <link rel="stylesheet" href="/common.css"> 5 <link rel="stylesheet" href="/common.css">
6 <style> 6 <style>
7 .running { 7 .running {
8 color: #666666; 8 color: #666666;
9 background-color: #fffc6c; 9 background-color: #fffc6c;
10 border-color: #c5c56d; 10 border-color: #c5c56d;
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 </style> 69 </style>
70 <link rel="stylesheet" href="https://ajax.googleapis.com/ajax/libs/jqueryui/1. 11.1/themes/smoothness/jquery-ui.css"> 70 <link rel="stylesheet" href="https://ajax.googleapis.com/ajax/libs/jqueryui/1. 11.1/themes/smoothness/jquery-ui.css">
71 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js "></script> 71 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js "></script>
72 <script src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.1/jquery-ui.m in.js"></script> 72 <script src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.1/jquery-ui.m in.js"></script>
73 <script> 73 <script>
74 var findit = {}; 74 var findit = {};
75 findit.analysisCompleted = '{{analysis_completed}}' == 'True'; 75 findit.analysisCompleted = '{{analysis_completed}}' == 'True';
76 findit.analysisFailed = '{{analysis_failed}}' == 'True'; 76 findit.analysisFailed = '{{analysis_failed}}' == 'True';
77 findit.builderUrl = 'https://build.chromium.org/p/{{master_name}}/builders/{ {builder_name}}'; 77 findit.builderUrl = 'https://build.chromium.org/p/{{master_name}}/builders/{ {builder_name}}';
78 findit.buildUrl = findit.builderUrl + '/builds/{{build_number}}'; 78 findit.buildUrl = findit.builderUrl + '/builds/{{build_number}}';
79 findit.triageReferenceAnalysisUrl = '/waterfall/build-failure?url=https://bu ild.chromium.org/p/{{triage_reference_analysis_master_name}}/builders/{{triage_r eference_analysis_builder_name}}/builds/{{triage_reference_analysis_build_number }}'
stgao 2016/06/30 01:08:16 Per coding style, JS statement should always end w
josiahk 2016/06/30 22:34:57 Done!
79 findit.analysisCorrect = '{{analysis_correct}}'; // Possible values: 'None' , 'True', or 'False'. 80 findit.analysisCorrect = '{{analysis_correct}}'; // Possible values: 'None' , 'True', or 'False'.
81 findit.analysisIsDuplicate = '{{analysis_is_duplicate}}' == 'True';
80 findit.showTriageHelpButton = '{{show_triage_help_button}}' == 'True'; 82 findit.showTriageHelpButton = '{{show_triage_help_button}}' == 'True';
81 findit.showDebugInfo = '{{show_debug_info}}' == 'True'; 83 findit.showDebugInfo = '{{show_debug_info}}' == 'True';
82 findit.analysisResult = {{analysis_result | tojson | safe}}; 84 findit.analysisResult = {{analysis_result | tojson | safe}};
83 findit.tryjobStatusMessageMap = {{status_message_map | tojson | safe}}; 85 findit.tryjobStatusMessageMap = {{status_message_map | tojson | safe}};
84 findit.defaultGitBaseUrl = 'https://chromium.googlesource.com/chromium/src.g it/+/'; 86 findit.defaultGitBaseUrl = 'https://chromium.googlesource.com/chromium/src.g it/+/';
85 87
86 function triageAnalysisResult(e) { 88 function triageAnalysisResult(e) {
87 var target = $(this); 89 var target = $(this);
88 if (target.hasClass('triaged')) 90 if (target.hasClass('triaged'))
89 return; 91 return;
90 92
91 var correct = target.hasClass('thumb-up'); 93 var correct = target.hasClass('thumb-up');
92 $.getJSON('/waterfall/triage-analysis?correct=' + correct + '&url=' + find it.buildUrl, function(data) { 94 $.getJSON('/waterfall/triage-analysis?correct=' + correct + '&url=' + find it.buildUrl, function(data) {
93 if (data['success']) { 95 if (data['success']) {
94 $('.triaged').addClass('triage').removeClass('triaged'); 96 $('.triaged').addClass('triage').removeClass('triaged');
95 target.addClass('triaged').removeClass('triage'); 97 target.addClass('triaged').removeClass('triage');
96 } else { 98 } else {
97 alert('Failed to update datastore. Please refresh and try again.'); 99 alert('Failed to update datastore. Please refresh and try again.');
98 } 100 }
101 $('#duplicates_marked').html("Number of matching build analyses that wer e also triaged: " + data['num_duplicate_analyses'])
stgao 2016/06/30 01:08:16 code style: no double quote ["] in JS code. Same f
josiahk 2016/06/30 22:34:57 Done.
102 $('#duplicate_reference').html("")
99 }).error(function(xhr) { 103 }).error(function(xhr) {
100 // Replace the whole page with errors from server side. 104 // Replace the whole page with errors from server side.
101 document.body.outerHTML = xhr.responseText; 105 document.body.outerHTML = xhr.responseText;
102 }); 106 });
103 107
104 e.preventDefault(); 108 e.preventDefault();
105 } 109 }
106 110
107 function triageHelp(e) { 111 function triageHelp(e) {
108 $('#triage_help_button').prop('disabled', true); 112 $('#triage_help_button').prop('disabled', true);
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 } else { 434 } else {
431 $('#triage-and-table').text('no failure is found'); 435 $('#triage-and-table').text('no failure is found');
432 } 436 }
433 437
434 if (findit.analysisCorrect == 'True') { 438 if (findit.analysisCorrect == 'True') {
435 $('.thumb-up').addClass('triaged').removeClass('triage'); 439 $('.thumb-up').addClass('triaged').removeClass('triage');
436 } else if (findit.analysisCorrect == 'False') { 440 } else if (findit.analysisCorrect == 'False') {
437 $('.thumb-down').addClass('triaged').removeClass('triage'); 441 $('.thumb-down').addClass('triaged').removeClass('triage');
438 } 442 }
439 443
444 if (findit.analysisIsDuplicate) {
stgao 2016/06/30 01:08:16 To double check: do we want to show this to everyo
josiahk 2016/06/30 22:34:57 Changed to show duplicate information only if show
445 $('#duplicate_reference').html("This analysis was automatically tria ged as a duplicate because of another build analysis: " +
446 "<a href='" + findit.triageReferenceA nalysisUrl + "'>{{triage_reference_analysis_master_name}}/" +
447 "{{triage_reference_analysis_builder_ name}}/{{triage_reference_analysis_build_number}}</a>")
448 }
449
440 if (findit.showTriageHelpButton) { 450 if (findit.showTriageHelpButton) {
441 $('#triage_help_button').click(triageHelp); 451 $('#triage_help_button').click(triageHelp);
442 } 452 }
443 } 453 }
444 } 454 }
445 455
446 $('#score-explanation-dialog').dialog({ 456 $('#score-explanation-dialog').dialog({
447 autoOpen: false, 457 autoOpen: false,
448 modal: true, 458 modal: true,
449 width: 600, 459 width: 600,
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 </tbody> 650 </tbody>
641 </table> 651 </table>
642 <br> 652 <br>
643 </div> 653 </div>
644 654
645 <div class="thumbs-up-down"> 655 <div class="thumbs-up-down">
646 <b>Feedback on Findit result:</b><br> 656 <b>Feedback on Findit result:</b><br>
647 <div class="triage thumb-up">Correct <img src="https://www.gstatic.com /images/icons/material/system/1x/thumb_up_black_24dp.png"/></div> 657 <div class="triage thumb-up">Correct <img src="https://www.gstatic.com /images/icons/material/system/1x/thumb_up_black_24dp.png"/></div>
648 <div class="triage thumb-down"><img src="https://www.gstatic.com/image s/icons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div> 658 <div class="triage thumb-down"><img src="https://www.gstatic.com/image s/icons/material/system/1x/thumb_down_black_24dp.png"/> Incorrect</div>
649 </div> 659 </div>
660 <div id="duplicates_marked"></div>
661 <div id="duplicate_reference"></div>
650 </div> 662 </div>
651 {% endif %} 663 {% endif %}
652 {% endif %} 664 {% endif %}
653 665
654 {% if show_triage_help_button %} 666 {% if show_triage_help_button %}
655 <br><br> 667 <br><br>
656 <div id="triage_help"> 668 <div id="triage_help">
657 <button id="triage_help_button">Triage help</button> 669 <button id="triage_help_button">Triage help</button>
658 <br> 670 <br>
659 <div id="triage_help_result"> 671 <div id="triage_help_result">
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 appearing in the failure log. (eg: file.h was changed and 703 appearing in the failure log. (eg: file.h was changed and
692 file_unittest.cc or file_impl.cc appeared in the log.)</li> 704 file_unittest.cc or file_impl.cc appeared in the log.)</li>
693 <li>1: The CL rolled a dependency within src/DEPS and a file of that 705 <li>1: The CL rolled a dependency within src/DEPS and a file of that
694 dependency appears in the failure log. (eg: third_party/dep 706 dependency appears in the failure log. (eg: third_party/dep
695 was changed in src/DEPS and third_party/dep/f.cpp appeared 707 was changed in src/DEPS and third_party/dep/f.cpp appeared
696 in the log.)</li> 708 in the log.)</li>
697 </ul> 709 </ul>
698 (More rules will be added when implemented.) 710 (More rules will be added when implemented.)
699 </div> 711 </div>
700 </body> 712 </body>
OLDNEW
« no previous file with comments | « appengine/findit/model/wf_analysis.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698