appengine/findit/common/base_handler.py - Issue 2086113004: [Findit] Show build analysis references in UI for Findit Cross-platform auto-triage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/common/base_handler.py

Issue 2086113004: [Findit] Show build analysis references in UI for Findit Cross-platform auto-triage (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@build-matching

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/common/base_handler.py

diff --git a/appengine/findit/common/base_handler.py b/appengine/findit/common/base_handler.py

index 11dd5f3b7fd5408b3dac022ef93b46eaf16de496..165175f9fdc86c05773656c92092f27997b1991d 100644

--- a/appengine/findit/common/base_handler.py

+++ b/appengine/findit/common/base_handler.py

@@ -23,10 +23,8 @@ JINJA_ENVIRONMENT = jinja2.Environment(

def ToJson(data):

return json.dumps(data, sort_keys=True) # Sort by key to keep order on UI.

chanli 2016/06/24 18:24:20 This two lines should not be deleted.

josiahk 2016/06/27 19:33:25 Done.

lijeffrey 2016/06/27 20:38:22 I think gpylin will complain if there aren't 2 lin

josiahk 2016/06/28 22:59:23 Fixed. Thanks!

JINJA_ENVIRONMENT.filters['tojson'] = ToJson

lijeffrey 2016/06/27 20:38:22 It also doesn't seem like there are any functional

class Permission(object):

ADMIN = 0

CORP_USER = 8

« no previous file with comments | « no previous file | appengine/findit/handlers/build_failure.py » ('j') | appengine/findit/handlers/test/triage_analysis_test.py » ('J')