Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: appengine/findit/handlers/build_failure.py

Issue 2086113004: [Findit] Show build analysis references in UI for Findit Cross-platform auto-triage (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@build-matching
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/build_failure.py
diff --git a/appengine/findit/handlers/build_failure.py b/appengine/findit/handlers/build_failure.py
index 9b75d58baa75fc41ca96a38be1535ed9ee64d537..e4b98d2db5eab0c6af14e14ae96f4ace8fa38423 100644
--- a/appengine/findit/handlers/build_failure.py
+++ b/appengine/findit/handlers/build_failure.py
@@ -275,7 +275,7 @@ class BuildFailure(BaseHandler):
# currently logged-in user is an admin, or if it is explicitly requested
# with parameter 'debug=1'.
return (
- users.is_current_user_admin() or self.request.get('debug') == '1')
+ users.is_current_user_admin() or self.request.get('debug') == '1')
def _ShowTriageHelpButton(self):
return users.is_current_user_admin()
@@ -295,8 +295,15 @@ class BuildFailure(BaseHandler):
'analysis_completed': analysis.completed,
'analysis_failed': analysis.failed,
'analysis_correct': analysis.correct,
+ 'analysis_duplicate': analysis.duplicate,
'triage_history': _GetTriageHistory(analysis),
'show_triage_help_button': self._ShowTriageHelpButton(),
+ 'triage_reference_analysis_master_name':
+ analysis.triage_reference_analysis_master_name,
+ 'triage_reference_analysis_builder_name':
+ analysis.triage_reference_analysis_builder_name,
+ 'triage_reference_analysis_build_number':
+ analysis.triage_reference_analysis_build_number
}
@staticmethod
@@ -314,7 +321,7 @@ class BuildFailure(BaseHandler):
result = try_job.compile_results[-1]
try_job_data['status'] = analysis_status.STATUS_TO_DESCRIPTION.get(
- try_job.status, 'unknown').lower()
+ try_job.status, 'unknown').lower()
try_job_data['url'] = result.get('url')
try_job_data['completed'] = try_job.completed
try_job_data['failed'] = try_job.failed
@@ -395,13 +402,13 @@ class BuildFailure(BaseHandler):
if analysis.failure_type == failure_type.COMPILE:
return {
- 'template': 'waterfall/compile_failure.html',
- 'data': self._PrepareDataForCompileFailure(analysis),
+ 'template': 'waterfall/compile_failure.html',
+ 'data': self._PrepareDataForCompileFailure(analysis),
}
else:
return {
- 'template': 'build_failure.html',
- 'data': self._PrepareDataForTestFailures(analysis, build_info),
+ 'template': 'build_failure.html',
+ 'data': self._PrepareDataForTestFailures(analysis, build_info),
}
def HandlePost(self): # pragma: no cover

Powered by Google App Engine
This is Rietveld 408576698