Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2085983002: binding: Window-returning attributes return null if a Window is detached. (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Window-returning attributes return null if a Window is detached. Makes the attributes that return a WindowProxy return null if the browsing context of the Window is detached in order to avoid crashes that are caused by accessing to a ScriptState for the detached browsing context. This is a kind of first aid, and not the right fix. The spec requires DOM attributes such as Window.parent or top to return the WindowProxy of the browsing context if it's detached. I.e. we need to fully support detached frames. BUG=621730, 621577 Committed: https://crrev.com/eb73fb7bd81b3253a36171851da62e15e5f88b41 Cr-Commit-Position: refs/heads/master@{#401007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ToV8.cpp View 1 chunk +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL? Hope this fix the crashes.
4 years, 6 months ago (2016-06-21 13:27:53 UTC) #2
haraken
LGTM to try.
4 years, 6 months ago (2016-06-21 13:42:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085983002/1
4 years, 6 months ago (2016-06-21 13:48:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 16:14:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 16:20:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb73fb7bd81b3253a36171851da62e15e5f88b41
Cr-Commit-Position: refs/heads/master@{#401007}

Powered by Google App Engine
This is Rietveld 408576698