Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2085863003: [wasm] No need for ModuleEnv when building import wrappers. (Closed)

Created:
4 years, 6 months ago by Mircea Trofin
Modified:
4 years, 6 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] No need for ModuleEnv when building import wrappers. Yanking out in an effort to reduce dependencies. We probably want to separate codegen into instance-specific and module-generic purpose - eventually. BUG= Committed: https://crrev.com/30e845384b0668c8b9f6fa37f90290fd97712232 Cr-Commit-Position: refs/heads/master@{#37126}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 3 chunks +6 lines, -9 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Mircea Trofin
4 years, 6 months ago (2016-06-21 05:47:28 UTC) #4
bradnelson
lgtm
4 years, 6 months ago (2016-06-21 06:08:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085863003/20001
4 years, 6 months ago (2016-06-21 06:08:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 06:10:43 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 06:13:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30e845384b0668c8b9f6fa37f90290fd97712232
Cr-Commit-Position: refs/heads/master@{#37126}

Powered by Google App Engine
This is Rietveld 408576698