Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: src/wasm/wasm-module.cc

Issue 2085863003: [wasm] No need for ModuleEnv when building import wrappers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 5c719405d2b51d0d5cfcd9b63e659afb15a3896b..62b4ab274f3d8f93a30b9fb804ee344bb3b94a79 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -486,12 +486,9 @@ struct CodeStats {
}
};
-bool CompileWrappersToImportedFunctions(Isolate* isolate,
- const WasmModule* module,
- const Handle<JSReceiver> ffi,
- WasmModuleInstance* instance,
- ErrorThrower* thrower, Factory* factory,
- ModuleEnv* module_env) {
+bool CompileWrappersToImportedFunctions(
+ Isolate* isolate, const WasmModule* module, const Handle<JSReceiver> ffi,
+ WasmModuleInstance* instance, ErrorThrower* thrower, Factory* factory) {
if (module->import_table.size() > 0) {
instance->import_code.reserve(module->import_table.size());
for (uint32_t index = 0; index < module->import_table.size(); ++index) {
@@ -505,8 +502,8 @@ bool CompileWrappersToImportedFunctions(Isolate* isolate,
if (function.is_null()) return false;
Handle<Code> code = compiler::CompileWasmToJSWrapper(
- isolate, module_env, function.ToHandleChecked(), import.sig,
- module_name, function_name);
+ isolate, function.ToHandleChecked(), import.sig, module_name,
+ function_name);
instance->import_code[index] = code;
}
}
@@ -837,7 +834,7 @@ MaybeHandle<JSObject> WasmModule::Instantiate(
// Compile wrappers to imported functions.
//-------------------------------------------------------------------------
if (!CompileWrappersToImportedFunctions(isolate, this, ffi, &instance,
- &thrower, factory, &module_env)) {
+ &thrower, factory)) {
return MaybeHandle<JSObject>();
}
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698