Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2085863002: Revert of Flip official Win builders to GN (on trunk). (patchset #1 id:1 of https://codereview.chro… (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw, brucedawson, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2774
Target Ref:
refs/pending/branch-heads/2774
Project:
chromium
Visibility:
Public.

Description

Revert of Flip official Win builders to GN (on trunk). (patchset #1 id:1 of https://codereview.chromium.org/2082823002/ ) Reason for revert: Didn't work - see crbug.com/621776. Original issue's description: > Flip official Win builders to GN (on trunk). > > This also flips the continuous official builders, but because those > are pulling MB configs from versioned code, this'll only actually > affect the trunk builder for now. When we branch, the branch builders > will also start to pick up these changes. > > R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org > BUG=605318 > > Committed: https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf > Cr-Commit-Position: refs/heads/master@{#400827} TBR=brettw@chromium.org,brucedawson@chromium.org,scottmg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605318 Review-Url: https://codereview.chromium.org/2077353003 Cr-Commit-Position: refs/heads/master@{#400887} (cherry picked from commit 217fb93cfc4e41ca74f55373834d9b9630842a41) Committed: https://chromium.googlesource.com/chromium/src/+/34ddc60db4147750937a5ea847e9958f1488a356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-21 04:26:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34ddc60db4147750937a5ea847e9958f1488a356.

Powered by Google App Engine
This is Rietveld 408576698