Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2077353003: Revert of Flip official Win builders to GN (on trunk). (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
brettw, brucedawson, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip official Win builders to GN (on trunk). (patchset #1 id:1 of https://codereview.chromium.org/2082823002/ ) Reason for revert: Didn't work - see crbug.com/621776. Original issue's description: > Flip official Win builders to GN (on trunk). > > This also flips the continuous official builders, but because those > are pulling MB configs from versioned code, this'll only actually > affect the trunk builder for now. When we branch, the branch builders > will also start to pick up these changes. > > R=brettw@chromium.org, brucedawson@chromium.org, scottmg@chromium.org > BUG=605318 > > Committed: https://crrev.com/44265dd04f839147986041fa9c32e9b3c758aebf > Cr-Commit-Position: refs/heads/master@{#400827} TBR=brettw@chromium.org,brucedawson@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605318 Committed: https://crrev.com/217fb93cfc4e41ca74f55373834d9b9630842a41 Cr-Commit-Position: refs/heads/master@{#400887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Flip official Win builders to GN (on trunk).
4 years, 6 months ago (2016-06-21 03:54:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2077353003/1
4 years, 6 months ago (2016-06-21 03:54:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 03:55:36 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 03:57:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/217fb93cfc4e41ca74f55373834d9b9630842a41
Cr-Commit-Position: refs/heads/master@{#400887}

Powered by Google App Engine
This is Rietveld 408576698