Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2085823003: Revert of [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
epertoso, oth, rmcilroy
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. (patchset #3 id:40001 of https://codereview.chromium.org/2084623002/ ) Reason for revert: [Sheriff] Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6304 Original issue's description: > [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. > > Make intrinsic ids a contiguous set of ids so that the switch statement can build > a table switch rather than doing a large if/else tree. > > BUG=v8:4822 > LOG=N > > Committed: https://crrev.com/36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea > Cr-Commit-Position: refs/heads/master@{#37135} TBR=epertoso@chromium.org,oth@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4822 Committed: https://crrev.com/1f815749115996a5355b0b7e403ccacfe3671550 Cr-Commit-Position: refs/heads/master@{#37137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -178 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M src/interpreter/bytecodes.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/interpreter-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 3 chunks +2 lines, -12 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 3 chunks +1 line, -32 lines 0 comments Download
M test/cctest/interpreter/bytecode-expectations-printer.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 28 chunks +58 lines, -58 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 7 chunks +13 lines, -13 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode.
4 years, 6 months ago (2016-06-21 11:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085823003/1
4 years, 6 months ago (2016-06-21 11:52:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 11:52:30 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 11:53:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f815749115996a5355b0b7e403ccacfe3671550
Cr-Commit-Position: refs/heads/master@{#37137}

Powered by Google App Engine
This is Rietveld 408576698