Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/interpreter/interpreter-intrinsics.h

Issue 2085823003: Revert of [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/interpreter-assembler.cc ('k') | src/interpreter/interpreter-intrinsics.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_INTERPRETER_INTRINSICS_H_ 5 #ifndef V8_INTERPRETER_INTERPRETER_INTRINSICS_H_
6 #define V8_INTERPRETER_INTERPRETER_INTRINSICS_H_ 6 #define V8_INTERPRETER_INTERPRETER_INTRINSICS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/base/smart-pointers.h" 9 #include "src/base/smart-pointers.h"
10 #include "src/builtins.h" 10 #include "src/builtins.h"
11 #include "src/frames.h" 11 #include "src/frames.h"
12 #include "src/interpreter/bytecodes.h" 12 #include "src/interpreter/bytecodes.h"
13 #include "src/interpreter/interpreter-assembler.h" 13 #include "src/interpreter/interpreter-assembler.h"
14 #include "src/runtime/runtime.h" 14 #include "src/runtime/runtime.h"
15 15
16 namespace v8 { 16 namespace v8 {
17 namespace internal { 17 namespace internal {
18 18
19 namespace compiler { 19 namespace compiler {
20 class Node; 20 class Node;
21 } // namespace compiler 21 } // namespace compiler
22 22
23 namespace interpreter {
24
25 // List of supported intrisics, with upper case name, lower case name and 23 // List of supported intrisics, with upper case name, lower case name and
26 // expected number of arguments (-1 denoting argument count is variable). 24 // expected number of arguments (-1 denoting argument count is variable).
27 #define INTRINSICS_LIST(V) \ 25 #define INTRINSICS_LIST(V) \
28 V(Call, call, -1) \ 26 V(Call, call, -1) \
29 V(IsArray, is_array, 1) \ 27 V(IsArray, is_array, 1) \
30 V(IsJSProxy, is_js_proxy, 1) \ 28 V(IsJSProxy, is_js_proxy, 1) \
31 V(IsJSReceiver, is_js_receiver, 1) \ 29 V(IsJSReceiver, is_js_receiver, 1) \
32 V(IsRegExp, is_regexp, 1) \ 30 V(IsRegExp, is_regexp, 1) \
33 V(IsSmi, is_smi, 1) \ 31 V(IsSmi, is_smi, 1) \
34 V(IsTypedArray, is_typed_array, 1) 32 V(IsTypedArray, is_typed_array, 1)
35 33
34 namespace interpreter {
35
36 class IntrinsicsHelper { 36 class IntrinsicsHelper {
37 public: 37 public:
38 enum class IntrinsicId {
39 #define DECLARE_INTRINSIC_ID(name, lower_case, count) k##name,
40 INTRINSICS_LIST(DECLARE_INTRINSIC_ID)
41 #undef DECLARE_INTRINSIC_ID
42 kIdCount
43 };
44 STATIC_ASSERT(static_cast<uint32_t>(IntrinsicId::kIdCount) <= kMaxUInt8);
45
46 explicit IntrinsicsHelper(InterpreterAssembler* assembler); 38 explicit IntrinsicsHelper(InterpreterAssembler* assembler);
47 39
48 compiler::Node* InvokeIntrinsic(compiler::Node* function_id, 40 compiler::Node* InvokeIntrinsic(compiler::Node* function_id,
49 compiler::Node* context, 41 compiler::Node* context,
50 compiler::Node* first_arg_reg, 42 compiler::Node* first_arg_reg,
51 compiler::Node* arg_count); 43 compiler::Node* arg_count);
52 44
53 static bool IsSupported(Runtime::FunctionId function_id); 45 static bool IsSupported(Runtime::FunctionId function_id);
54 static IntrinsicId FromRuntimeId(Runtime::FunctionId function_id);
55 static Runtime::FunctionId ToRuntimeId(IntrinsicId intrinsic_id);
56 46
57 private: 47 private:
58 enum InstanceTypeCompareMode { 48 enum InstanceTypeCompareMode {
59 kInstanceTypeEqual, 49 kInstanceTypeEqual,
60 kInstanceTypeGreaterThanOrEqual 50 kInstanceTypeGreaterThanOrEqual
61 }; 51 };
62 52
63 compiler::Node* IsInstanceType(compiler::Node* input, int type); 53 compiler::Node* IsInstanceType(compiler::Node* input, int type);
64 compiler::Node* CompareInstanceType(compiler::Node* map, int type, 54 compiler::Node* CompareInstanceType(compiler::Node* map, int type,
65 InstanceTypeCompareMode mode); 55 InstanceTypeCompareMode mode);
66 void AbortIfArgCountMismatch(int expected, compiler::Node* actual); 56 void AbortIfArgCountMismatch(int expected, compiler::Node* actual);
67 57
68 #define DECLARE_INTRINSIC_HELPER(name, lower_case, count) \ 58 #define DECLARE_INTRINSIC_HELPER(name, lower_case, count) \
69 compiler::Node* name(compiler::Node* input, compiler::Node* arg_count, \ 59 compiler::Node* name(compiler::Node* input, compiler::Node* arg_count, \
70 compiler::Node* context); 60 compiler::Node* context);
71 INTRINSICS_LIST(DECLARE_INTRINSIC_HELPER) 61 INTRINSICS_LIST(DECLARE_INTRINSIC_HELPER)
72 #undef DECLARE_INTRINSIC_HELPER 62 #undef DECLARE_INTRINSIC_HELPER
73 63
74 InterpreterAssembler* assembler_; 64 InterpreterAssembler* assembler_;
75 65
76 DISALLOW_COPY_AND_ASSIGN(IntrinsicsHelper); 66 DISALLOW_COPY_AND_ASSIGN(IntrinsicsHelper);
77 }; 67 };
78 68
79 } // namespace interpreter 69 } // namespace interpreter
80 } // namespace internal 70 } // namespace internal
81 } // namespace v8 71 } // namespace v8
82 72
83 #endif 73 #endif
OLDNEW
« no previous file with comments | « src/interpreter/interpreter-assembler.cc ('k') | src/interpreter/interpreter-intrinsics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698