PPC/s390: [cleanup] Remove dead code from DeclareLookupSlot and rename it

PPC/s390: [cleanup] Remove dead code from DeclareLookupSlot and rename it

Port cbc6adc86cc2697785d311ff5bf9f736c7d9e725

Original commit message:

    Runtime_DeclareLookupSlot is used when generating code for var and function declarations
    originating in an eval. Over time, it's accumulated quite a bit of cruft, which this CL removes:

      - With legacy const gone, lookup slots never have any property attributes.
      - There was a bit signaling that the variable was from an eval, but that was redundant since
        DeclareLookupSlot is only used for eval.
      - Some Proxy-related code didn't make sense here.

    Its name was also not terribly clear: while "LookupSlot" is used in several places, this
    particular function is only used for declaring variables and functions inside sloppy eval.
    Renamed (and split into two) to make this clear for future archeologists.

    Also added various DCHECKs to check the assumptions being made.

R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/97ae43ac01c487d9d9c2bcdcee8fd2ce79b290d5
Cr-Commit-Position: refs/heads/master@{#37117}

[JaideepBajwa, 2016-06-20 19:04:30]

PTAL

[john.yan, 2016-06-20 19:29:51]

lgtm

[JaideepBajwa, 2016-06-20 20:10:18]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-06-20 20:10:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085623003/1

[commit-bot: I haz the power, 2016-06-20 20:35:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 20:39:26]

Description was changed from

==========
PPC/s390: [cleanup] Remove dead code from DeclareLookupSlot and rename it

Port cbc6adc86cc2697785d311ff5bf9f736c7d9e725

Original commit message:

    Runtime_DeclareLookupSlot is used when generating code for var and function
declarations
    originating in an eval. Over time, it's accumulated quite a bit of cruft,
which this CL removes:

      - With legacy const gone, lookup slots never have any property attributes.
      - There was a bit signaling that the variable was from an eval, but that
was redundant since
        DeclareLookupSlot is only used for eval.
      - Some Proxy-related code didn't make sense here.

    Its name was also not terribly clear: while "LookupSlot" is used in several
places, this
    particular function is only used for declaring variables and functions
inside sloppy eval.
    Renamed (and split into two) to make this clear for future archeologists.

    Also added various DCHECKs to check the assumptions being made.

R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N
==========

to

==========
PPC/s390: [cleanup] Remove dead code from DeclareLookupSlot and rename it

Port cbc6adc86cc2697785d311ff5bf9f736c7d9e725

Original commit message:

    Runtime_DeclareLookupSlot is used when generating code for var and function
declarations
    originating in an eval. Over time, it's accumulated quite a bit of cruft,
which this CL removes:

      - With legacy const gone, lookup slots never have any property attributes.
      - There was a bit signaling that the variable was from an eval, but that
was redundant since
        DeclareLookupSlot is only used for eval.
      - Some Proxy-related code didn't make sense here.

    Its name was also not terribly clear: while "LookupSlot" is used in several
places, this
    particular function is only used for declaring variables and functions
inside sloppy eval.
    Renamed (and split into two) to make this clear for future archeologists.

    Also added various DCHECKs to check the assumptions being made.

R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=
LOG=N

Committed: https://crrev.com/97ae43ac01c487d9d9c2bcdcee8fd2ce79b290d5
Cr-Commit-Position: refs/heads/master@{#37117}
==========

[commit-bot: I haz the power, 2016-06-20 20:39:27]

Patchset 1 (id:??) landed as
https://crrev.com/97ae43ac01c487d9d9c2bcdcee8fd2ce79b290d5
Cr-Commit-Position: refs/heads/master@{#37117}