Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2085623003: PPC/s390: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
734 EmitDebugCheckDeclarationContext(variable); 734 EmitDebugCheckDeclarationContext(variable);
735 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 735 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
736 __ StoreP(ip, ContextMemOperand(cp, variable->index())); 736 __ StoreP(ip, ContextMemOperand(cp, variable->index()));
737 // No write barrier since the_hole_value is in old space. 737 // No write barrier since the_hole_value is in old space.
738 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 738 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
739 } 739 }
740 break; 740 break;
741 741
742 case VariableLocation::LOOKUP: { 742 case VariableLocation::LOOKUP: {
743 Comment cmnt(masm_, "[ VariableDeclaration"); 743 Comment cmnt(masm_, "[ VariableDeclaration");
744 DCHECK_EQ(VAR, mode);
745 DCHECK(!hole_init);
744 __ mov(r4, Operand(variable->name())); 746 __ mov(r4, Operand(variable->name()));
745 // Declaration nodes are always introduced in one of four modes. 747 __ Push(r4);
746 DCHECK(IsDeclaredVariableMode(mode)); 748 __ CallRuntime(Runtime::kDeclareEvalVar);
747 DCHECK(!hole_init);
748 __ LoadSmiLiteral(r2, Smi::FromInt(0)); // Indicates no initial value.
749 __ Push(r4, r2);
750 __ Push(Smi::FromInt(variable->DeclarationPropertyAttributes()));
751 __ CallRuntime(Runtime::kDeclareLookupSlot);
752 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 749 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
753 break; 750 break;
754 } 751 }
755 } 752 }
756 } 753 }
757 754
758 void FullCodeGenerator::VisitFunctionDeclaration( 755 void FullCodeGenerator::VisitFunctionDeclaration(
759 FunctionDeclaration* declaration) { 756 FunctionDeclaration* declaration) {
760 VariableProxy* proxy = declaration->proxy(); 757 VariableProxy* proxy = declaration->proxy();
761 Variable* variable = proxy->var(); 758 Variable* variable = proxy->var();
(...skipping 30 matching lines...) Expand all
792 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 789 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
793 break; 790 break;
794 } 791 }
795 792
796 case VariableLocation::LOOKUP: { 793 case VariableLocation::LOOKUP: {
797 Comment cmnt(masm_, "[ FunctionDeclaration"); 794 Comment cmnt(masm_, "[ FunctionDeclaration");
798 __ mov(r4, Operand(variable->name())); 795 __ mov(r4, Operand(variable->name()));
799 PushOperand(r4); 796 PushOperand(r4);
800 // Push initial value for function declaration. 797 // Push initial value for function declaration.
801 VisitForStackValue(declaration->fun()); 798 VisitForStackValue(declaration->fun());
802 PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes())); 799 CallRuntimeWithOperands(Runtime::kDeclareEvalFunction);
803 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);
804 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 800 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
805 break; 801 break;
806 } 802 }
807 } 803 }
808 } 804 }
809 805
810 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) { 806 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
811 // Call the runtime to declare the globals. 807 // Call the runtime to declare the globals.
812 __ mov(r3, Operand(pairs)); 808 __ mov(r3, Operand(pairs));
813 __ LoadSmiLiteral(r2, Smi::FromInt(DeclareGlobalsFlags())); 809 __ LoadSmiLiteral(r2, Smi::FromInt(DeclareGlobalsFlags()));
(...skipping 2884 matching lines...) Expand 10 before | Expand all | Expand 10 after
3698 DCHECK(kOSRBranchInstruction == br_instr); 3694 DCHECK(kOSRBranchInstruction == br_instr);
3699 3695
3700 DCHECK(interrupt_address == 3696 DCHECK(interrupt_address ==
3701 isolate->builtins()->OnStackReplacement()->entry()); 3697 isolate->builtins()->OnStackReplacement()->entry());
3702 return ON_STACK_REPLACEMENT; 3698 return ON_STACK_REPLACEMENT;
3703 } 3699 }
3704 3700
3705 } // namespace internal 3701 } // namespace internal
3706 } // namespace v8 3702 } // namespace v8
3707 #endif // V8_TARGET_ARCH_S390 3703 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698