Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: lib/kernel_visitor.dart

Issue 2085613002: Constant get and invoke are never called. (Closed) Base URL: git@github.com:dart-lang/rasta.git@enum
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/kernel/regression/constant_get_and_invoke.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/kernel_visitor.dart
diff --git a/lib/kernel_visitor.dart b/lib/kernel_visitor.dart
index 2b6c00b13d79cc8680cdaa992821e291c6cbac1b..0634e7b3c674445ae0e829d74098e8a5f90bab11 100644
--- a/lib/kernel_visitor.dart
+++ b/lib/kernel_visitor.dart
@@ -1248,18 +1248,20 @@ class KernelVisitor extends Object
}
@override
- ir.Throw visitConstantGet(Send node, ConstantExpression constant, _) {
- return buildUnsupported(node, "ConstantGet");
+ visitConstantGet(Send node, ConstantExpression constant, _) {
+ // TODO(ahe): This method is never called. Is it a bug in semantic visitor?
+ return internalError(node, "ConstantGet");
}
@override
- ir.Throw visitConstantInvoke(
+ visitConstantInvoke(
Send node,
ConstantExpression constant,
NodeList arguments,
CallStructure callStructure,
_) {
- return buildUnsupported(node, "ConstantInvoke");
+ // TODO(ahe): This method is never called. Is it a bug in semantic visitor?
+ return internalError(node, "ConstantInvoke");
}
@override
« no previous file with comments | « no previous file | test/kernel/regression/constant_get_and_invoke.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698