Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2085583005: Allow DCI to pick up contents from Internet Plug-Ins on OS X. (Closed)

Created:
4 years, 6 months ago by waffles
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow DCI to pick up contents from Internet Plug-Ins on OS X. On other platforms, this should have no effect, since DIR_INTERNAL_PLUGINS == DIR_COMPONENTS. BUG=601928 Committed: https://crrev.com/2ff5b4cd942039905c9e26a5abdb9607e1338329 Cr-Commit-Position: refs/heads/master@{#401114}

Patch Set 1 #

Patch Set 2 : Clarified comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/component_updater_paths.h View 1 2 chunks +7 lines, -0 lines 1 comment Download
M components/component_updater/component_updater_paths.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M components/component_updater/default_component_installer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/default_component_installer.cc View 1 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
waffles
kerrnel, thestig: PTAL; thanks in advance for your time. I suggested moving Flash on OS ...
4 years, 6 months ago (2016-06-21 20:24:55 UTC) #2
Lei Zhang
chrome/ side is trivial, so that lgtm
4 years, 6 months ago (2016-06-21 20:30:07 UTC) #3
Greg K
On 2016/06/21 20:30:07, Lei Zhang wrote: > chrome/ side is trivial, so that lgtm LGTM
4 years, 6 months ago (2016-06-21 20:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085583005/20001
4 years, 6 months ago (2016-06-21 21:11:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 21:38:24 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2ff5b4cd942039905c9e26a5abdb9607e1338329 Cr-Commit-Position: refs/heads/master@{#401114}
4 years, 6 months ago (2016-06-21 21:39:52 UTC) #9
Eugene But (OOO till 7-30)
Commenting because I'm not sure what should I use for |components_system_root_key_alt| on iOS :) https://codereview.chromium.org/2085583005/diff/20001/components/component_updater/component_updater_paths.h ...
4 years, 6 months ago (2016-06-22 02:06:34 UTC) #11
waffles
4 years, 6 months ago (2016-06-22 04:03:42 UTC) #12
Message was sent while issue was closed.
On 2016/06/22 02:06:34, Eugene But wrote:
> Commenting because I'm not sure what should I use for
> |components_system_root_key_alt| on iOS :)
> 
>
https://codereview.chromium.org/2085583005/diff/20001/components/component_up...
> File components/component_updater/component_updater_paths.h (right):
> 
>
https://codereview.chromium.org/2085583005/diff/20001/components/component_up...
> components/component_updater/component_updater_paths.h:44: int
> components_system_root_key_alt,
> Could you please update function comments and explain what
> |components_system_root_key_alt| is.

Ah, yes; whoops. Will do. In the meantime, it's safe to use the same thing for
components_system_root_key and components_system_root_key_alt.

Powered by Google App Engine
This is Rietveld 408576698