components/component_updater/default_component_installer.h - Issue 2085583005: Allow DCI to pick up contents from Internet Plug-Ins on OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/default_component_installer.h

Issue 2085583005: Allow DCI to pick up contents from Internet Plug-Ins on OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarified comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/component_updater/component_updater_paths.h ('K') | « components/component_updater/component_updater_paths.cc ('k') | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/default_component_installer.h

diff --git a/components/component_updater/default_component_installer.h b/components/component_updater/default_component_installer.h

index e8f8df29876c497696af9a0672f4ff07264dc834..f728b431f5ce1b22ca62c9b1c2c1294ecc1c7639 100644

--- a/components/component_updater/default_component_installer.h

+++ b/components/component_updater/default_component_installer.h

@@ -122,7 +122,7 @@ class DefaultComponentInstaller : public update_client::CrxInstaller {

// files (as opposed to in the user data directory), sets current_* to the

// values associated with that installation and returns true; otherwise,

// returns false.

- bool FindPreinstallation();

+ bool FindPreinstallation(const base::FilePath& root);

bool InstallHelper(const base::DictionaryValue& manifest,

const base::FilePath& unpack_path,

const base::FilePath& install_path);