Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2085483002: [memory-infra] Add DumpStateUponFailure method to MultiBrowserSharedState (Closed)

Created:
4 years, 6 months ago by petrcermak
Modified:
4 years, 6 months ago
Reviewers:
perezju, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-infra] Add DumpStateUponFailure method to MultiBrowserSharedState This is necessary for https://codereview.chromium.org/2074183002/ (Telemetry patch in the Catapult repository). BUG=612140 Committed: https://crrev.com/a604c7548e4b1ed89dfc8a8de3f0b5a501214b17 Cr-Commit-Position: refs/heads/master@{#400687}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/perf/page_sets/dual_browser_story.py View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 6 months ago (2016-06-20 13:34:17 UTC) #2
perezju
lgtm
4 years, 6 months ago (2016-06-20 13:39:26 UTC) #3
nednguyen
lgtm
4 years, 6 months ago (2016-06-20 14:44:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085483002/1
4 years, 6 months ago (2016-06-20 14:45:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 15:50:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 15:52:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a604c7548e4b1ed89dfc8a8de3f0b5a501214b17
Cr-Commit-Position: refs/heads/master@{#400687}

Powered by Google App Engine
This is Rietveld 408576698