Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: tools/perf/page_sets/dual_browser_story.py

Issue 2085483002: [memory-infra] Add DumpStateUponFailure method to MultiBrowserSharedState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/dual_browser_story.py
diff --git a/tools/perf/page_sets/dual_browser_story.py b/tools/perf/page_sets/dual_browser_story.py
index e511044f5dcf4e1a0f5d10fa6c7851feb313fd53..14412d635506ad3e724a3e90c98dc05b025218af 100644
--- a/tools/perf/page_sets/dual_browser_story.py
+++ b/tools/perf/page_sets/dual_browser_story.py
@@ -190,6 +190,14 @@ class MultiBrowserSharedState(story_module.SharedState):
logging.exception('Error while closing browser: %s', browser_type)
self._browsers = None # Not usable after tearing down.
+ def DumpStateUponFailure(self, unused_story, unused_results):
+ if self._browsers:
+ for browser_type, browser in self._browsers.iteritems():
+ logging.info('vvvvv BROWSER STATE BELOW FOR \'%s\' vvvvv', browser_type)
+ browser.DumpStateUponFailure()
+ else:
+ logging.warning('Cannot dump browser states: No browsers.')
+
class SinglePage(story_module.Story):
def __init__(self, name, url, browser_type, phase):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698