Issue 2085443002: Remove the need for copy-pasting code in ChromeRenderViewTests.

Issue 2085443002: Remove the need for copy-pasting code in ChromeRenderViewTests. (Closed)

Created:
4 years, 6 months ago by Alexander Semashko

Modified:
4 years, 6 months ago

Reviewers:
Nathan Parker, sky

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove the need for copy-pasting code in ChromeRenderViewTests. BUG= Committed: https://crrev.com/37b98c8a982d7c9cd3f253d518d41aba6d6a7693 Cr-Commit-Position: refs/heads/master@{#400757}

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -16 lines)			Patch
M	chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc	View	1 2	2 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_test.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/base/chrome_render_view_test.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 11 (3 generated)

Alexander Semashko

On 2016/06/20 15:56:19, Nathan Parker wrote: > lgtm > > Is there any bug assoc'd ...

4 years, 6 months ago (2016-06-20 15:59:00 UTC) #4

Nathan Parker

nope, not required if this is just an out-of-the-blue fix. If it's associated with other ...

4 years, 6 months ago (2016-06-20 16:22:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085443002/40001

4 years, 6 months ago (2016-06-20 19:21:57 UTC) #8

commit-bot: I haz the power

4 years, 6 months ago (2016-06-20 20:08:57 UTC) #11

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/37b98c8a982d7c9cd3f253d518d41aba6d6a7693
Cr-Commit-Position: refs/heads/master@{#400757}