Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3158)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc

Issue 2085443002: Remove the need for copy-pasting code in ChromeRenderViewTests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove one more forgotten include. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/base/chrome_render_view_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
index 9b1653648fff0bd482953302002b64220f21ed9e..7a22fa7688cde92f45e28693472050bc977ce973 100644
--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc
@@ -13,17 +13,13 @@
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "chrome/renderer/chrome_content_renderer_client.h"
-#include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
-#include "chrome/renderer/extensions/chrome_extensions_renderer_client.h"
#include "chrome/renderer/safe_browsing/features.h"
#include "chrome/renderer/safe_browsing/mock_feature_extractor_clock.h"
#include "chrome/renderer/safe_browsing/test_utils.h"
-#include "chrome/renderer/spellchecker/spellcheck.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "content/public/common/content_switches.h"
#include "content/public/renderer/render_frame.h"
#include "content/public/test/test_utils.h"
-#include "extensions/renderer/dispatcher.h"
#include "net/base/escape.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -200,17 +196,7 @@ class PhishingDOMFeatureExtractorTest : public ChromeRenderViewTest {
content::ContentRendererClient* CreateContentRendererClient() override {
ChromeContentRendererClient* client = new TestChromeContentRendererClient();
-#if defined(ENABLE_EXTENSIONS)
- extension_dispatcher_delegate_.reset(
- new ChromeExtensionsDispatcherDelegate());
- ChromeExtensionsRendererClient* ext_client =
- ChromeExtensionsRendererClient::GetInstance();
- ext_client->SetExtensionDispatcherForTest(base::WrapUnique(
- new extensions::Dispatcher(extension_dispatcher_delegate_.get())));
-#endif
-#if defined(ENABLE_SPELLCHECK)
- client->SetSpellcheck(new SpellCheck());
-#endif
+ InitChromeContentRendererClient(client);
return client;
}
« no previous file with comments | « no previous file | chrome/test/base/chrome_render_view_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698