Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2085433003: Ignore listMarker nodes and sync from left to right after a jump command. (Closed)

Created:
4 years, 6 months ago by David Tseng
Modified:
4 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore listMarker nodes and sync from left to right after a jump command. BUG=619240 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0601429f6d4612207f7ec4ded9dbc424c7573328 Cr-Commit-Position: refs/heads/master@{#400841}

Patch Set 1 #

Patch Set 2 : m #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 2 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
David Tseng
4 years, 6 months ago (2016-06-20 18:31:12 UTC) #4
dmazzoni
lgtm
4 years, 6 months ago (2016-06-20 19:50:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085433003/1
4 years, 6 months ago (2016-06-20 21:52:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/231158)
4 years, 6 months ago (2016-06-20 22:22:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085433003/20001
4 years, 6 months ago (2016-06-20 23:02:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 23:57:51 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 23:59:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0601429f6d4612207f7ec4ded9dbc424c7573328
Cr-Commit-Position: refs/heads/master@{#400841}

Powered by Google App Engine
This is Rietveld 408576698