chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js - Issue 2085433003: Ignore listMarker nodes and sync from left to right after a jump command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

Issue 2085433003: Ignore listMarker nodes and sync from left to right after a jump command. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: m Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

index 354a58fc962212e71e3381f6fea0096027f73ced..4821a332f4833688fd7da90f6ac979a270a6d260 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js

@@ -34,7 +34,7 @@ AutomationUtil.findNodePre = function(cur, dir, pred) {

if (!cur)

return null;

- if (pred(cur))

+ if (pred(cur) && !AutomationPredicate.shouldIgnoreNode(cur))

return cur;

var child = dir == Dir.BACKWARD ? cur.lastChild : cur.firstChild;

@@ -69,7 +69,7 @@ AutomationUtil.findNodePost = function(cur, dir, pred) {

child.previousSibling : child.nextSibling;

}

- if (pred(cur))

+ if (pred(cur) && !AutomationPredicate.shouldIgnoreNode(cur))

return cur;

return null;