Subzero, MIPS32: Cross-testing enabled for MIPS32

Makefile.standalone

Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index f3a5d877191cfce20594178941332d77d4d2a227..81c288f48645e253cc863fd47ea4c468ad4c563e 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -512,13 +512,16 @@ $(OBJDIR)/unittest/AssemblerX8664: $(OBJDIR)/unittest
 
 RT_SRC := runtime/szrt.c runtime/szrt_ll.ll runtime/szrt_profiler.c \
           runtime/szrt_asm_x8632.s runtime/szrt_asm_x8664.s \
-          runtime/szrt_asm_arm32.s runtime/szrt_asan.c
+          runtime/szrt_asm_arm32.s \
+          runtime/szrt_asm_mips32.s \
+          runtime/szrt_asan.c
 RT_OBJ := build/runtime/szrt_native_x8632.o build/runtime/szrt_sb_x8632.o \
           build/runtime/szrt_nonsfi_x8632.o \
           build/runtime/szrt_native_x8664.o build/runtime/szrt_sb_x8664.o \
           build/runtime/szrt_nonsfi_x8664.o \
           build/runtime/szrt_native_arm32.o build/runtime/szrt_sb_arm32.o \
           build/runtime/szrt_nonsfi_arm32.o \
+          build/runtime/szrt_native_mips32.o build/runtime/szrt_sb_mips32.o \
           build/runtime/szrt_asan_x8632.o build/runtime/szrt_asan_x8664.o \
           build/runtime/szrt_asan_arm32.o
 
@@ -560,6 +563,8 @@ check-xtest: $(OBJDIR)/pnacl-sz make_symlink runtime \
           -i x8664,native,sse4.1,test_vector_ops \
           -i x8664,sandbox,sse4.1,Om1 \
           -i arm32 \
+          -i mips32 \

[Jim Stichnoth, 2016/08/23 14:56:48]

Change these two mips32 lines to this single line:
  -i mips32,native,Om1,simple_loop

This restricts the mips32 cross tests to the single currently working test, when
"make -f Makefile.standalone check-xtest" is run.

[Jim Stichnoth, 2016/09/02 15:49:31]

Update: After you "git pull --rebase" to pull in
https://codereview.chromium.org/2271053006/ , put "-i
mips32,native,Om1,simple_loop" in the "ifdef MIPS" section.

[obucinac, 2016/09/05 16:55:59]

Done.

+          -i mips32,native \
           -e arm32,sandbox,hwdiv-arm
 	PNACL_BIN_PATH=$(PNACL_BIN_PATH) \
 	$(LLVM_SRC_PATH)/utils/lit/lit.py -sv $(CHECK_XTEST_TESTS)
@@ -615,6 +620,11 @@ ifeq ($(TARGET),arm32)
   SETUP=SetupGccArmOpt
   SPEC := --filetype=obj
 endif
+ifeq ($(TARGET),mips32)

[Jim Stichnoth, 2016/08/23 14:56:48]

Should probably add a comment noting that
native_client/tests/spec2k/{Makefile.common,run_all.sh} do not currently have
MIPS configs, so those would need to be added for proper Subzero testing here.

[obucinac, 2016/09/05 16:55:59]

Done.

+  TARGETFLAG=mips32
+  SETUP=SetupGccMipsOpt
+  ;SPEC := --filetype=asm

[Jim Stichnoth, 2016/08/23 14:56:48]

Remove the ';'.

(Not sure if that was meant as a comment character which is actually '#', but
this line without the ';' should be correct.)

[obucinac, 2016/09/05 16:55:59]

Done.

+endif
 SPECFLAGS := -O2
 SPECRUN := --run
 %.spec2k: % $(OBJDIR)/pnacl-sz make_symlink runtime