Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2085213003:
Conditionalize new code which fetches stack traces upon failure. (Closed)
|
Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 6 months ago Reviewers:
Zhenyao Mo CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vmiura, cblume, ynovikov Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConditionalize new code which fetches stack traces upon failure.
BUG=609252
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/6ce7da1ad477f7e562961a155c69381219ac6835
Cr-Commit-Position: refs/heads/master@{#401509}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 ========== to ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + zmo@chromium.org
Mo: please review. Thanks. (Since Victor's not in the office right now)
P.S. Tested locally on an Android device via failure injection. Code works as expected.
lgtm
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085213003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
Description was changed from ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
On 2016/06/23 01:33:33, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) The NVIDIA Mac Retina bots are probably oversubscribed for the (optional) WebGL 2.0 conformance tests. Bypassing the CQ.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085213003/1
Message was sent while issue was closed.
Description was changed from ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== Conditionalize new code which fetches stack traces upon failure. BUG=609252 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/6ce7da1ad477f7e562961a155c69381219ac6835 Cr-Commit-Position: refs/heads/master@{#401509} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6ce7da1ad477f7e562961a155c69381219ac6835 Cr-Commit-Position: refs/heads/master@{#401509} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
