Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 2085213003: Conditionalize new code which fetches stack traces upon failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py
index be917d7771dd4de0f997d376ee6a05f21b46458c..dffc795e6fd28e7867caa0910ae37dd32de28494 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance.py
@@ -84,8 +84,13 @@ class WebglConformanceValidator(gpu_test_base.ValidatorBase):
def ValidateAndMeasurePage(self, page, tab, results):
if not _DidWebGLTestSucceed(tab):
- is_valid_dump, trace_output = tab.browser.GetStackTrace()
messages = _WebGLTestMessages(tab)
+ is_valid_dump = False
+ # Problems have been seen attempting to get stack traces on
+ # Android via this API; see crbug.com/609252. Skip this logic
+ # there for the time being.
+ if tab.browser.platform.GetOSName() != 'android':
+ is_valid_dump, trace_output = tab.browser.GetStackTrace()
if is_valid_dump:
messages += '\nStack Trace:\n' + trace_output
raise page_test.Failure(messages)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698