Issue 2085193002: V4L2VEA: fix keyframe is not generated on nyan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2085193002: V4L2VEA: fix keyframe is not generated on nyan (Closed)

Created:
4 years, 6 months ago by wuchengli

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

More Reviews

Description

V4L2VEA: fix keyframe is not generated on nyan Nyan does not support V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME yet. But it reports success to V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME and keyframe is not generated. Switch the order of two controls and try V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE first. BUG=chromium:612198 TEST=Run VEA test on nyan and oak. Review-Url: https://codereview.chromium.org/2069923005 Cr-Commit-Position: refs/heads/master@{#400328} (cherry picked from commit 5a83a05e8647c71db1e155dec4c030d5f581e380) Committed: https://chromium.googlesource.com/chromium/src/+/87cc040a0d78a96d8a7dcfd6acb1f6fc821ed740

Patch Set 1 #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	content/common/gpu/media/v4l2_video_encode_accelerator.cc	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

wuchengli

4 years, 6 months ago (2016-06-22 02:56:21 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
87cc040a0d78a96d8a7dcfd6acb1f6fc821ed740.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages