Convert TrayBubbleView to wm common types

mash: Optionally set bubble widget parent container via delegate

Use the delegate mechanism on ash to support both aura and mus.

This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
which is step toward converting TrayBubbleView to wm common types.

I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
mechanism is used in ~30 places inside //chrome.

BUG=619636
TEST=ash_unittests, views_unittests, manually check that system tray bubbles
still open/close propertly

Committed: https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e
Cr-Commit-Position: refs/heads/master@{#401469}

[James Cook, 2016-06-22 20:58:20]

Description was changed from

==========
WIP: Convert TrayBubbleView to wm common types

BUG=
==========

to

==========
mash: Optionally set bubble widget parent container via delegate

Use the delegate mechanism on ash to support both aura and mus.

This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
which is step toward converting TrayBubbleView to wm common types.

I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
mechanism is used in ~30 places inside //chrome.

BUG=619636
TEST=ash_unittests, views_unittests, manually check that system tray bubbles
still open/close propertly
==========

[James Cook, 2016-06-22 21:01:26]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-22 21:01:27]

msw, please take a look.

https://codereview.chromium.org/2092473002/diff/20001/ash/system/web_notifica...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/web_notifica...
ash/system/web_notification/web_notification_tray.cc:419: WmLookup::Get()
This duplicates the code in system_tray.cc, but I thought it was clearer if each
file explicitly showed what container its widget would end up in. I could also
move it to a shared location in the superclass TrayBackgroundView next to
GetBubbleAnchorRect(). Let me know what you prefer.

[msw, 2016-06-22 23:00:23]

lgtm with minor optional nits.

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.cc:669: // views::TrayBubbleView::Delegate
overrides:
nit: I'm not a big fan unless the file is consistent about this.

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray_bubble.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray_bubble.cc:194: // The TrayBubbleView will use
|anchor| and |tray| to determine the parent
nit: |tray_|

https://codereview.chromium.org/2092473002/diff/20001/ash/system/web_notifica...
File ash/system/web_notification/web_notification_tray.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/web_notifica...
ash/system/web_notification/web_notification_tray.cc:419: WmLookup::Get()
On 2016/06/22 21:01:27, James Cook wrote:
> This duplicates the code in system_tray.cc, but I thought it was clearer if
each
> file explicitly showed what container its widget would end up in. I could also
> move it to a shared location in the superclass TrayBackgroundView next to
> GetBubbleAnchorRect(). Let me know what you prefer.

I don't have a strong opinion; hopefully there aren't other places it's needed.

https://codereview.chromium.org/2092473002/diff/20001/ui/views/bubble/tray_bu...
File ui/views/bubble/tray_bubble_view.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ui/views/bubble/tray_bu...
ui/views/bubble/tray_bubble_view.cc:403: // views::BubbleDialogDelegateView
overrides:
ditto nit: I'm not a big fan unless the file is consistent about this.

[James Cook, 2016-06-22 23:06:29]

Thanks for the review.

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray.cc:669: // views::TrayBubbleView::Delegate
overrides:
On 2016/06/22 23:00:23, msw wrote:
> nit: I'm not a big fan unless the file is consistent about this.

Removed.

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
File ash/system/tray/system_tray_bubble.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ash/system/tray/system_...
ash/system/tray/system_tray_bubble.cc:194: // The TrayBubbleView will use
|anchor| and |tray| to determine the parent
On 2016/06/22 23:00:23, msw wrote:
> nit: |tray_|

Done.

https://codereview.chromium.org/2092473002/diff/20001/ui/views/bubble/tray_bu...
File ui/views/bubble/tray_bubble_view.cc (right):

https://codereview.chromium.org/2092473002/diff/20001/ui/views/bubble/tray_bu...
ui/views/bubble/tray_bubble_view.cc:403: // views::BubbleDialogDelegateView
overrides:
On 2016/06/22 23:00:23, msw wrote:
> ditto nit: I'm not a big fan unless the file is consistent about this.

Removed.

[James Cook, 2016-06-22 23:07:05]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-22 23:07:06]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2092473002/#ps40001
(title: "review feedback")

[commit-bot: I haz the power, 2016-06-22 23:07:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2092473002/40001

[commit-bot: I haz the power, 2016-06-22 23:58:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-23 00:01:05]

Description was changed from

==========
mash: Optionally set bubble widget parent container via delegate

Use the delegate mechanism on ash to support both aura and mus.

This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
which is step toward converting TrayBubbleView to wm common types.

I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
mechanism is used in ~30 places inside //chrome.

BUG=619636
TEST=ash_unittests, views_unittests, manually check that system tray bubbles
still open/close propertly
==========

to

==========
mash: Optionally set bubble widget parent container via delegate

Use the delegate mechanism on ash to support both aura and mus.

This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
which is step toward converting TrayBubbleView to wm common types.

I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
mechanism is used in ~30 places inside //chrome.

BUG=619636
TEST=ash_unittests, views_unittests, manually check that system tray bubbles
still open/close propertly

Committed: https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e
Cr-Commit-Position: refs/heads/master@{#401469}
==========

[commit-bot: I haz the power, 2016-06-23 00:01:06]

Patchset 3 (id:??) landed as
https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e
Cr-Commit-Position: refs/heads/master@{#401469}