Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 2085023003: Simplify detection of new, test-related RenderFrameHosts. (Closed)

Created:
4 years, 6 months ago by Łukasz Anforowicz
Modified:
4 years, 6 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify detection of new, test-related RenderFrameHosts. Listening for WebContentsObserver::RenderFrameCreated is sufficient for detecting new test frames - there is no need to also listen for WebContentsObserver::RenderFrameHostChanged. BUG=583485 Committed: https://crrev.com/bb36d01b4e5e0e4161fe5144acfc671566e0acba Cr-Commit-Position: refs/heads/master@{#401143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M content/shell/browser/layout_test/blink_test_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/browser/layout_test/secondary_test_window_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/secondary_test_window_observer.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
Charlie, can you take a look please? (if it looks okay, then feel free to ...
4 years, 6 months ago (2016-06-21 22:00:09 UTC) #2
Charlie Reis
Thanks for the cleanup and verifying it still works! I agree that RenderFrameCreated should be ...
4 years, 6 months ago (2016-06-21 22:52:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085023003/1
4 years, 6 months ago (2016-06-21 22:53:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 00:04:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 00:05:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb36d01b4e5e0e4161fe5144acfc671566e0acba
Cr-Commit-Position: refs/heads/master@{#401143}

Powered by Google App Engine
This is Rietveld 408576698