content/shell/browser/layout_test/blink_test_controller.cc - Issue 2085023003: Simplify detection of new, test-related RenderFrameHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/blink_test_controller.cc

Issue 2085023003: Simplify detection of new, test-related RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/blink_test_controller.h ('k') | content/shell/browser/layout_test/layout_test_devtools_frontend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/blink_test_controller.cc

diff --git a/content/shell/browser/layout_test/blink_test_controller.cc b/content/shell/browser/layout_test/blink_test_controller.cc

index 34ba9822438dac3233476077d7251302eb1322ad..bb83758940ffd03fe0511262c99ce5de71994951 100644

--- a/content/shell/browser/layout_test/blink_test_controller.cc

+++ b/content/shell/browser/layout_test/blink_test_controller.cc

@@ -472,12 +472,6 @@ void BlinkTestController::RenderFrameCreated(

HandleNewRenderFrameHost(render_frame_host);

}

-void BlinkTestController::RenderFrameHostChanged(RenderFrameHost* old_host,

- RenderFrameHost* new_host) {

- DCHECK(CalledOnValidThread());

- HandleNewRenderFrameHost(new_host);

void BlinkTestController::DevToolsProcessCrashed() {

DCHECK(CalledOnValidThread());

printer_->AddErrorMessage("#CRASHED - devtools");