Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4387)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 2084903002: Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc
index 7da63a8c3cf88c8445fbd85ae8b92b91bc489b3e..455327d7af9f6218588449814c77b188fd23c7b0 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover.cc
@@ -296,27 +296,23 @@ BrowsingDataRemover::TimeRange BrowsingDataRemover::Unbounded() {
}
// static
-BrowsingDataRemover::TimeRange BrowsingDataRemover::Period(TimePeriod period) {
+BrowsingDataRemover::TimeRange BrowsingDataRemover::Period(
+ browsing_data::TimePeriod period) {
switch (period) {
- case LAST_HOUR:
- content::RecordAction(
- UserMetricsAction("ClearBrowsingData_LastHour"));
+ case browsing_data::LAST_HOUR:
+ content::RecordAction(UserMetricsAction("ClearBrowsingData_LastHour"));
break;
- case LAST_DAY:
- content::RecordAction(
- UserMetricsAction("ClearBrowsingData_LastDay"));
+ case browsing_data::LAST_DAY:
+ content::RecordAction(UserMetricsAction("ClearBrowsingData_LastDay"));
break;
- case LAST_WEEK:
- content::RecordAction(
- UserMetricsAction("ClearBrowsingData_LastWeek"));
+ case browsing_data::LAST_WEEK:
+ content::RecordAction(UserMetricsAction("ClearBrowsingData_LastWeek"));
break;
- case FOUR_WEEKS:
- content::RecordAction(
- UserMetricsAction("ClearBrowsingData_LastMonth"));
+ case browsing_data::FOUR_WEEKS:
+ content::RecordAction(UserMetricsAction("ClearBrowsingData_LastMonth"));
break;
- case EVERYTHING:
- content::RecordAction(
- UserMetricsAction("ClearBrowsingData_Everything"));
+ case browsing_data::EVERYTHING:
+ content::RecordAction(UserMetricsAction("ClearBrowsingData_Everything"));
break;
}
return TimeRange(CalculateBeginDeleteTime(period), base::Time::Max());
@@ -1080,30 +1076,6 @@ void BrowsingDataRemover::ClearSettingsForOneTypeWithPredicate(
}
}
-base::Time BrowsingDataRemover::CalculateBeginDeleteTime(
- TimePeriod time_period) {
- base::TimeDelta diff;
- base::Time delete_begin_time = base::Time::Now();
- switch (time_period) {
- case LAST_HOUR:
- diff = base::TimeDelta::FromHours(1);
- break;
- case LAST_DAY:
- diff = base::TimeDelta::FromHours(24);
- break;
- case LAST_WEEK:
- diff = base::TimeDelta::FromHours(7*24);
- break;
- case FOUR_WEEKS:
- diff = base::TimeDelta::FromHours(4*7*24);
- break;
- case EVERYTHING:
- delete_begin_time = base::Time();
- break;
- }
- return delete_begin_time - diff;
-}
-
bool BrowsingDataRemover::AllDone() {
return !waiting_for_clear_autofill_origin_urls_ &&
!waiting_for_clear_cache_ &&

Powered by Google App Engine
This is Rietveld 408576698