Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3301)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.h

Issue 2084903002: Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover.h
diff --git a/chrome/browser/browsing_data/browsing_data_remover.h b/chrome/browser/browsing_data/browsing_data_remover.h
index 6995ccad3500ff113fd806811ea52c7fb53dc20a..9e12be054b20b9017f3bf3c858329eb5e34f4cd3 100644
--- a/chrome/browser/browsing_data/browsing_data_remover.h
+++ b/chrome/browser/browsing_data/browsing_data_remover.h
@@ -21,6 +21,7 @@
#include "base/time/time.h"
#include "build/build_config.h"
#include "chrome/common/features.h"
+#include "components/browsing_data/browsing_data_utils.h"
#include "components/content_settings/core/common/content_settings_pattern.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/keyed_service/core/keyed_service.h"
@@ -70,23 +71,6 @@ class BrowsingDataRemover : public KeyedService
#endif
{
public:
- // Time period ranges available when doing browsing data removals.
- // TODO(msramek): As this is now reused on Android, we should move it
- // to browsing_data_counter_utils.h (and rename appropriately), so that
- // all fundamental types related to browsing data on all platforms are in
- // one place.
- //
- // A Java counterpart will be generated for this enum.
- // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser
- enum TimePeriod {
- LAST_HOUR = 0,
- LAST_DAY,
- LAST_WEEK,
- FOUR_WEEKS,
- EVERYTHING,
- TIME_PERIOD_LAST = EVERYTHING
- };
-
// Mask used for Remove.
enum RemoveDataMask {
REMOVE_APPCACHE = 1 << 0,
@@ -223,10 +207,7 @@ class BrowsingDataRemover : public KeyedService
static TimeRange Unbounded();
- static TimeRange Period(TimePeriod period);
-
- // Calculate the begin time for the deletion range specified by |time_period|.
- static base::Time CalculateBeginDeleteTime(TimePeriod time_period);
+ static TimeRange Period(browsing_data::TimePeriod period);
// Is the BrowsingDataRemover currently in the process of removing data?
bool is_removing() { return is_removing_; }

Powered by Google App Engine
This is Rietveld 408576698