Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/browsing_data/passwords_counter.cc

Issue 2084903002: Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed round 2 of comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/passwords_counter.cc
diff --git a/chrome/browser/browsing_data/passwords_counter.cc b/chrome/browser/browsing_data/passwords_counter.cc
index 6fc68cbc8f06396b5aab3594ce1a88b36745d213..71b60e72da267ab92988b202a6a89fc08a9cd6dd 100644
--- a/chrome/browser/browsing_data/passwords_counter.cc
+++ b/chrome/browser/browsing_data/passwords_counter.cc
@@ -4,10 +4,12 @@
#include "chrome/browser/browsing_data/passwords_counter.h"
#include "chrome/browser/password_manager/password_store_factory.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/common/pref_names.h"
#include "components/password_manager/core/browser/password_store.h"
-PasswordsCounter::PasswordsCounter() : pref_name_(prefs::kDeletePasswords) {}
+PasswordsCounter::PasswordsCounter(Profile* profile)
+ : BrowsingDataCounter(prefs::kDeletePasswords), profile_(profile) {}
PasswordsCounter::~PasswordsCounter() {
if (store_)
@@ -16,17 +18,14 @@ PasswordsCounter::~PasswordsCounter() {
void PasswordsCounter::OnInitialized() {
store_ = PasswordStoreFactory::GetForProfile(
Bernhard Bauer 2016/06/27 17:09:45 Also preexisting code, but: PasswordStoreFactory::
ioanap 2016/06/28 14:12:35 Done.
- GetProfile(), ServiceAccessType::EXPLICIT_ACCESS).get();
+ profile_, ServiceAccessType::EXPLICIT_ACCESS)
+ .get();
if (store_)
store_->AddObserver(this);
else
LOG(ERROR) << "No password store! Cannot count passwords.";
Bernhard Bauer 2016/06/27 17:09:45 This is also a bit strange... Under which circumst
ioanap 2016/06/28 14:12:36 Added the DCHECK since it looks like it can't happ
}
-const std::string& PasswordsCounter::GetPrefName() const {
- return pref_name_;
-}
-
void PasswordsCounter::Count() {
if (!store_) {
ReportResult(0);

Powered by Google App Engine
This is Rietveld 408576698