Moved BrowsingDataCounter and part of BrowsingDataCounterUtils to components.

chrome/browser/browsing_data/passwords_counter.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/passwords_counter.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "components/password_manager/core/browser/password_store.h"
 
-PasswordsCounter::PasswordsCounter() : pref_name_(prefs::kDeletePasswords) {}
+PasswordsCounter::PasswordsCounter(Profile* profile)
+    : BrowsingDataCounter(prefs::kDeletePasswords), profile_(profile) {}
 
 PasswordsCounter::~PasswordsCounter() {
   if (store_)
     store_->RemoveObserver(this);
 }
 
 void PasswordsCounter::OnInitialized() {
   store_ = PasswordStoreFactory::GetForProfile(

[Bernhard Bauer, 2016/06/27 17:09:45]

Also preexisting code, but: PasswordStoreFactory::GetForProfile() returns a
scoped_refptr, so storing a raw pointer is pretty ick.

[ioanap, 2016/06/28 14:12:35]

Done.

-      GetProfile(), ServiceAccessType::EXPLICIT_ACCESS).get();
+               profile_, ServiceAccessType::EXPLICIT_ACCESS)
+               .get();
   if (store_)
     store_->AddObserver(this);
   else
     LOG(ERROR) << "No password store! Cannot count passwords.";

[Bernhard Bauer, 2016/06/27 17:09:45]

This is also a bit strange... Under which circumstances would this happen? If
it's something like only in a testing profile, that's perfectly legitimate and a
LOG(ERROR) is just going to produce spam. If we _think_ it can't happen, it's
better to DCHECK it anyway, so we'd crash if the assumption turns out to be
wrong.

[ioanap, 2016/06/28 14:12:36]

Added the DCHECK since it looks like it can't happen.

 }
 
-const std::string& PasswordsCounter::GetPrefName() const {
-  return pref_name_;
-}
-
 void PasswordsCounter::Count() {
   if (!store_) {
     ReportResult(0);
     return;
   }
 
   cancelable_task_tracker()->TryCancelAll();
   // TODO(msramek): We don't actually need the logins themselves, just their
   // count. Consider implementing |PasswordStore::CountAutofillableLogins|.
   // This custom request should also allow us to specify the time range, so that
   // we can use it to filter the login creation date in the database.
   store_->GetAutofillableLogins(this);
 }
 
 void PasswordsCounter::OnGetPasswordStoreResults(
     ScopedVector<autofill::PasswordForm> results) {
   base::Time start = GetPeriodStart();
   ReportResult(std::count_if(
       results.begin(),
       results.end(),
       [start](const autofill::PasswordForm* form) {
         return form->date_created >= start;
       }));
 }
 
 void PasswordsCounter::OnLoginsChanged(
     const password_manager::PasswordStoreChangeList& changes) {
   Restart();
 }