Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2084833002: Merge "Menulist SELECT element should update layout when an OPTION content is changed." to M52. (Closed)

Created:
4 years, 6 months ago by tkent
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge "Menulist SELECT element should update layout when an OPTION content is changed." to M52. r374629 exposed this bug. Before r374629, removing OPTION content triggered style recalc and layout for the SELECT element. Now we need to ask for layout manually. BUG=619837 Review-Url: https://codereview.chromium.org/2075533002 Cr-Commit-Position: refs/heads/master@{#400395} (cherry picked from commit 717d9d1c80c2925b3781b417f9d9ab44fc04bc29) Committed: https://chromium.googlesource.com/chromium/src/+/7f3dd4e3ced28e039e71257baea326a2501272be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 6 months ago (2016-06-21 04:11:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f3dd4e3ced28e039e71257baea326a2501272be.

Powered by Google App Engine
This is Rietveld 408576698