Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2084763003: Remove check for cmake in android make script and update android setup docs. (Closed)

Created:
4 years, 6 months ago by stani
Modified:
4 years, 6 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove check for cmake in android make script. Update docs explaining how to setup Android SDK. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084763003 DOCS_PREVIEW= https://skia.org/?cl=2084763003 Committed: https://skia.googlesource.com/skia/+/a80bb676d3432c202c633f9e6fb05d2348d7aa04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +0 lines, -7 lines 0 comments Download
M site/user/quick/android.md View 1 chunk +11 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stani
4 years, 6 months ago (2016-06-21 17:55:02 UTC) #4
djsollen
lgtm
4 years, 6 months ago (2016-06-21 18:34:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084763003/1
4 years, 6 months ago (2016-06-21 19:24:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9209)
4 years, 6 months ago (2016-06-21 19:32:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084763003/1
4 years, 6 months ago (2016-06-21 19:46:00 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 20:13:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a80bb676d3432c202c633f9e6fb05d2348d7aa04

Powered by Google App Engine
This is Rietveld 408576698