Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Unified Diff: platform_tools/android/bin/android_setup.sh

Issue 2084763003: Remove check for cmake in android make script and update android setup docs. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | site/user/quick/android.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_setup.sh
diff --git a/platform_tools/android/bin/android_setup.sh b/platform_tools/android/bin/android_setup.sh
index 0a6fd5f0abd7b52c7eb4bb7b64b9a740c51e2c2f..d09292241666b7436a1260ee7055477c78138c43 100755
--- a/platform_tools/android/bin/android_setup.sh
+++ b/platform_tools/android/bin/android_setup.sh
@@ -87,13 +87,6 @@ fi
if [ "$SKIA_VULKAN" == "true" ]; then
export GYP_DEFINES="skia_vulkan=1 $GYP_DEFINES"
- # add cmake from the SDK to your path if it doesn't exist
- if [ ! -d "${ANDROID_SDK_ROOT}/cmake" ]; then
- echo "The Android SDK Tools version of CMake is required to build Vulkan. ${ANDROID_SDK_ROOT}/cmake"
- exit 1
- else
- export PATH=${ANDROID_SDK_ROOT}/cmake/bin:$PATH
- fi
fi
# Helper function to configure the GYP defines to the appropriate values
« no previous file with comments | « no previous file | site/user/quick/android.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698