mash: Migrate tray IME view to wm common types, move to //ash/common

mash: Migrate tray IME view to wm common types, move to //ash/common

* Move IMEObserver and VirtualKeyboardObserver to WmSystemTrayNotifier.
* Fix the tray IME unit test so it doesn't need StatusAreaWidget.

The rest of VirtualKeyboardController will have to wait until
MaximizeModeController can be migrated.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8
Cr-Commit-Position: refs/heads/master@{#401060}

[James Cook, 2016-06-21 00:04:14]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-06-21 00:04:15]

msw, please take a look.

[msw, 2016-06-21 01:27:24]

lgtm with nits

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:32: void
WmSystemTrayNotifier::AddIMEObserver(IMEObserver* observer) {
nit: order after *clock*observer (to match decls)

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:78: void
WmSystemTrayNotifier::NotifyRefreshIME() {
ditto nit: order after notify*clock

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.h (right):

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.h:55: void NotifyRefreshIME();
nit: order after notify.*clock (to parallel add/remove order, ditto for impls).

[James Cook, 2016-06-21 17:31:01]

Thanks for the review.

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:32: void
WmSystemTrayNotifier::AddIMEObserver(IMEObserver* observer) {
On 2016/06/21 01:27:24, msw wrote:
> nit: order after *clock*observer (to match decls)

Done.

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.cc:78: void
WmSystemTrayNotifier::NotifyRefreshIME() {
On 2016/06/21 01:27:24, msw wrote:
> ditto nit: order after notify*clock

Done.

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
File ash/common/system/tray/wm_system_tray_notifier.h (right):

https://codereview.chromium.org/2086503003/diff/1/ash/common/system/tray/wm_s...
ash/common/system/tray/wm_system_tray_notifier.h:55: void NotifyRefreshIME();
On 2016/06/21 01:27:24, msw wrote:
> nit: order after notify.*clock (to parallel add/remove order, ditto for
impls).

Given that I've screwed up function ordering in this file twice now, I've
reorganized it to put the notify calls next to the add/remove. This also
consolidates two of the #ifdef blocks, which seems nicer.

[msw, 2016-06-21 17:50:21]

lgtm with a very optional comment nit.

https://codereview.chromium.org/2086503003/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2086503003/diff/40001/ash/common/system/tray/...
ash/common/system/tray/wm_system_tray_notifier.cc:95:
/////////////////////////////////////////////////////////////////////////
optional nit: remove or make this 80 chars, perhaps with a comment below or no
blank line between the decoration and #if? Maybe consider adding comments for
each section above that parallel the decls? (maybe not...)

[James Cook, 2016-06-21 17:59:54]

https://codereview.chromium.org/2086503003/diff/40001/ash/common/system/tray/...
File ash/common/system/tray/wm_system_tray_notifier.cc (right):

https://codereview.chromium.org/2086503003/diff/40001/ash/common/system/tray/...
ash/common/system/tray/wm_system_tray_notifier.cc:95:
/////////////////////////////////////////////////////////////////////////
On 2016/06/21 17:50:20, msw wrote:
> optional nit: remove or make this 80 chars, perhaps with a comment below or no
> blank line between the decoration and #if? Maybe consider adding comments for
> each section above that parallel the decls? (maybe not...)

I took out this decoration. I tried adding per-section comments but it didn't
look good, so I left them out.

[James Cook, 2016-06-21 18:00:00]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-06-21 18:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2086503003/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-06-21 18:00:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2086503003/60001

[commit-bot: I haz the power, 2016-06-21 18:59:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-21 19:08:52]

Description was changed from

==========
mash: Migrate tray IME view to wm common types, move to //ash/common

* Move IMEObserver and VirtualKeyboardObserver to WmSystemTrayNotifier.
* Fix the tray IME unit test so it doesn't need StatusAreaWidget.

The rest of VirtualKeyboardController will have to wait until
MaximizeModeController can be migrated.

BUG=619636
TEST=ash_unittests
==========

to

==========
mash: Migrate tray IME view to wm common types, move to //ash/common

* Move IMEObserver and VirtualKeyboardObserver to WmSystemTrayNotifier.
* Fix the tray IME unit test so it doesn't need StatusAreaWidget.

The rest of VirtualKeyboardController will have to wait until
MaximizeModeController can be migrated.

BUG=619636
TEST=ash_unittests

Committed: https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8
Cr-Commit-Position: refs/heads/master@{#401060}
==========

[commit-bot: I haz the power, 2016-06-21 19:08:53]

Patchset 4 (id:??) landed as
https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8
Cr-Commit-Position: refs/heads/master@{#401060}