Remove LayoutView::doingFullPaintInvalidation()

Remove LayoutView::doingFullPaintInvalidation()

It was an optimization before slimming paint to shortcut per-object
paint invalidation. Remove it because we do need per-object paint
invalidation.

BUG=600008
Committed: https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4
Cr-Commit-Position: refs/heads/master@{#401697}

[Xianzhu, 2016-06-22 18:48:01]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-06-22 18:48:02]

Please see https://codereview.chromium.org/2084723002/#ps40001 for layout
expectation changes.

The test cases needing full paint invalidation of the LayoutView still get fully
invalidated, e.g. fixed background with gradient fill.

[chrishtr, 2016-06-22 20:14:48]

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutView.cpp:206:
IncludeScrollbarsInRect includeScrollbars = document().settings() &&
document().settings()->rootLayerScrolls() ? IncludeScrollbars :
ExcludeScrollbars;
This stuff about scrollbars and offsetWidth() comparisons doesn't seem to be
present before this patch. Why is it newly needed?

[Xianzhu, 2016-06-22 20:37:26]

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutView.cpp:206:
IncludeScrollbarsInRect includeScrollbars = document().settings() &&
document().settings()->rootLayerScrolls() ? IncludeScrollbars :
ExcludeScrollbars;
On 2016/06/22 20:14:48, chrishtr wrote:
> This stuff about scrollbars and offsetWidth() comparisons doesn't seem to be
> present before this patch. Why is it newly needed?

The existed through viewLogicalWidthForBoxSizing() (callsite at old code line
216, implementation
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...).

[chrishtr, 2016-06-22 21:33:29]

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutView.cpp:206:
IncludeScrollbarsInRect includeScrollbars = document().settings() &&
document().settings()->rootLayerScrolls() ? IncludeScrollbars :
ExcludeScrollbars;
On 2016/06/22 at 20:37:26, Xianzhu wrote:
> On 2016/06/22 20:14:48, chrishtr wrote:
> > This stuff about scrollbars and offsetWidth() comparisons doesn't seem to be
> > present before this patch. Why is it newly needed?
> 
> The existed through viewLogicalWidthForBoxSizing() (callsite at old code line
216, implementation
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...).

I see. Why are you changing the way it's written then?

[Xianzhu, 2016-06-22 21:50:00]

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutView.cpp (right):

https://codereview.chromium.org/2084723002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutView.cpp:206:
IncludeScrollbarsInRect includeScrollbars = document().settings() &&
document().settings()->rootLayerScrolls() ? IncludeScrollbars :
ExcludeScrollbars;
On 2016/06/22 21:33:29, chrishtr wrote:
> On 2016/06/22 at 20:37:26, Xianzhu wrote:
> > On 2016/06/22 20:14:48, chrishtr wrote:
> > > This stuff about scrollbars and offsetWidth() comparisons doesn't seem to
be
> > > present before this patch. Why is it newly needed?
> > 
> > The existed through viewLogicalWidthForBoxSizing() (callsite at old code
line
> 216, implementation
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...).
> 
> I see. Why are you changing the way it's written then?

Now we check physical instead of logical width or height change before calling
mustInvalidateFillLayersPaintOn(Width|Height)Change(). Previously we forced full
invalidation if writing mode is horizontal to avoid the mismatch.

[chrishtr, 2016-06-22 21:56:36]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-06-22 21:56:37]

lgtm

[commit-bot: I haz the power, 2016-06-22 21:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084723002/60001

[Xianzhu, 2016-06-22 22:00:58]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-06-22 22:01:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2084723002/#ps80001
(title: "More NeedsRebaselines")

[commit-bot: I haz the power, 2016-06-22 22:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084723002/80001

[commit-bot: I haz the power, 2016-06-22 23:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 23:29:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-06-23 18:04:17]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-06-23 18:04:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2084723002/#ps100001
(title: "More NeedsRebaselines")

[commit-bot: I haz the power, 2016-06-23 18:04:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084723002/100001

[commit-bot: I haz the power, 2016-06-23 19:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 19:03:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-06-23 19:04:13]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-06-23 19:04:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084723002/100001

[commit-bot: I haz the power, 2016-06-23 20:13:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-23 20:15:33]

Description was changed from

==========
Remove LayoutView::doingFullPaintInvalidation()

It was an optimization before slimming paint to shortcut per-object
paint invalidation. Remove it because we do need per-object paint
invalidation.

BUG=600008
==========

to

==========
Remove LayoutView::doingFullPaintInvalidation()

It was an optimization before slimming paint to shortcut per-object
paint invalidation. Remove it because we do need per-object paint
invalidation.

BUG=600008

Committed: https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4
Cr-Commit-Position: refs/heads/master@{#401697}
==========

[commit-bot: I haz the power, 2016-06-23 20:15:35]

Patchset 6 (id:??) landed as
https://crrev.com/c31119bc5e336b3f827f7c0ad5425b35fa5216f4
Cr-Commit-Position: refs/heads/master@{#401697}