Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2084723002: Remove LayoutView::doingFullPaintInvalidation() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More NeedsRebaselines Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index c2bc13f9d104dfbd0107264d59ce9fdebe2ac1a5..b116c5ce3a6788f8f7c0e882ef3e0004eaaf62cc 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -212,7 +212,6 @@ DEFINE_TRACE(FrameView)
void FrameView::reset()
{
m_hasPendingLayout = false;
- m_doFullPaintInvalidation = false;
m_layoutSchedulingEnabled = true;
m_inSynchronousPostLayout = false;
m_layoutCount = 0;
@@ -1008,7 +1007,6 @@ void FrameView::layout()
if (m_firstLayout) {
setScrollbarsSuppressed(true);
- m_doFullPaintInvalidation = true;
m_firstLayout = false;
m_lastViewportSize = layoutSize(IncludeScrollbars);
m_lastZoomFactor = layoutViewItem().style()->zoom();
@@ -1040,10 +1038,6 @@ void FrameView::layout()
else if (rootLayoutObject && rootLayoutObject->stretchesToViewport())
rootLayoutObject->setChildNeedsLayout();
}
-
- // We need to set m_doFullPaintInvalidation before triggering layout as LayoutObject::checkForPaintInvalidation
- // checks the boolean to disable local paint invalidations.
- m_doFullPaintInvalidation |= layoutViewItem().shouldDoFullPaintInvalidationForNextLayout();
}
TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(TRACE_DISABLED_BY_DEFAULT("blink.debug.layout.trees"), "LayoutTree",
@@ -1132,8 +1126,6 @@ void FrameView::invalidatePaintIfNeeded(const PaintInvalidationState& paintInval
if (m_frame->selection().isCaretBoundsDirty())
m_frame->selection().invalidateCaretRect();
- m_doFullPaintInvalidation = false;
-
// Temporary callback for crbug.com/487345,402044
// TODO(ojan): Make this more general to be used by PositionObserver
// and rAF throttling.
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.h ('k') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698