Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2084713002: Don't set a default action for ToolbarActionsBarBubbles. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Don't set a default action for ToolbarActionsBarBubbles. This isn't totally correct; some of these bubbles should have defaults and some should not. But this was the behavior previous to dc0d234f7c87 so the more conservative approach is to revert to the old behavior and later change/improve individual bubbles that should have defaults by adding them. This patch is designed to be easy/safe to merge to M52. BUG=621122 Review-Url: https://codereview.chromium.org/2076993002 Cr-Commit-Position: refs/heads/master@{#400503} (cherry picked from commit 0013e8398ca2cb80185a08bcf14358bc4310b27a) Committed: https://chromium.googlesource.com/chromium/src/+/389f429ccbf0bddbc85a19abae863370f012c7cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
4 years, 6 months ago (2016-06-20 21:14:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
389f429ccbf0bddbc85a19abae863370f012c7cb.

Powered by Google App Engine
This is Rietveld 408576698