Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2076993002: Don't set a default action for ToolbarActionsBarBubbles. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set a default action for ToolbarActionsBarBubbles. This isn't totally correct; some of these bubbles should have defaults and some should not. But this was the behavior previous to dc0d234f7c87 so the more conservative approach is to revert to the old behavior and later change/improve individual bubbles that should have defaults by adding them. This patch is designed to be easy/safe to merge to M52. BUG=621122 Committed: https://crrev.com/0013e8398ca2cb80185a08bcf14358bc4310b27a Cr-Commit-Position: refs/heads/master@{#400503}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Evan Stade
4 years, 6 months ago (2016-06-17 17:11:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076993002/1
4 years, 6 months ago (2016-06-17 17:11:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 17:50:16 UTC) #6
Peter Kasting
LGTM https://codereview.chromium.org/2076993002/diff/1/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc File chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc (right): https://codereview.chromium.org/2076993002/diff/1/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc#newcode106 chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc:106: return ui::DIALOG_BUTTON_NONE; Nit: May want a relevant TODO ...
4 years, 6 months ago (2016-06-17 19:14:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076993002/20001
4 years, 6 months ago (2016-06-17 20:22:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 21:07:16 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 21:09:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0013e8398ca2cb80185a08bcf14358bc4310b27a
Cr-Commit-Position: refs/heads/master@{#400503}

Powered by Google App Engine
This is Rietveld 408576698