Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2084703002: mojo: Re-allow empty callbacks to be passed to the bindings. (Closed)

Created:
4 years, 6 months ago by Elliot Glaysher
Modified:
4 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Re-allow empty callbacks to be passed to the bindings. mojo::Callback just ignored null callbacks. Transitioning to base::Callback, which crashes on null callbacks, caused crashes in some compositor components. BUG=620840 Committed: https://crrev.com/97aa5fec3372fc8b658a007e095d614b91893622 Cr-Commit-Position: refs/heads/master@{#400789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Elliot Glaysher
4 years, 6 months ago (2016-06-20 20:40:40 UTC) #2
yzshen1
lgtm
4 years, 6 months ago (2016-06-20 20:44:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2084703002/1
4 years, 6 months ago (2016-06-20 20:44:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 21:35:17 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 21:39:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97aa5fec3372fc8b658a007e095d614b91893622
Cr-Commit-Position: refs/heads/master@{#400789}

Powered by Google App Engine
This is Rietveld 408576698