Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 2084703002: mojo: Re-allow empty callbacks to be passed to the bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {%- import "interface_macros.tmpl" as interface_macros %} 1 {%- import "interface_macros.tmpl" as interface_macros %}
2 {%- import "struct_macros.tmpl" as struct_macros %} 2 {%- import "struct_macros.tmpl" as struct_macros %}
3 3
4 {%- set class_name = interface.name %} 4 {%- set class_name = interface.name %}
5 {%- set proxy_name = interface.name ~ "Proxy" %} 5 {%- set proxy_name = interface.name ~ "Proxy" %}
6 {%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %} 6 {%- set namespace_as_string = "%s"|format(namespace|replace(".","::")) %}
7 7
8 {%- macro alloc_params(struct, params, message, serialization_context, 8 {%- macro alloc_params(struct, params, message, serialization_context,
9 description) %} 9 description) %}
10 ({{params}})->DecodePointers(); 10 ({{params}})->DecodePointers();
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 }; 138 };
139 bool {{class_name}}_{{method.name}}_ForwardToCallback::Accept( 139 bool {{class_name}}_{{method.name}}_ForwardToCallback::Accept(
140 mojo::Message* message) { 140 mojo::Message* message) {
141 internal::{{class_name}}_{{method.name}}_ResponseParams_Data* params = 141 internal::{{class_name}}_{{method.name}}_ResponseParams_Data* params =
142 reinterpret_cast<internal::{{class_name}}_{{method.name}}_ResponseParams_D ata*>( 142 reinterpret_cast<internal::{{class_name}}_{{method.name}}_ResponseParams_D ata*>(
143 message->mutable_payload()); 143 message->mutable_payload());
144 144
145 {{alloc_params(method.response_param_struct, "params", "message", 145 {{alloc_params(method.response_param_struct, "params", "message",
146 "&serialization_context_", 146 "&serialization_context_",
147 "{{class_name}}_{{method.name}} response")}} 147 "{{class_name}}_{{method.name}} response")}}
148 callback_.Run({{pass_params(method.response_parameters)}}); 148 if (!callback_.is_null())
149 callback_.Run({{pass_params(method.response_parameters)}});
149 return true; 150 return true;
150 } 151 }
151 {%- endif %} 152 {%- endif %}
152 {%- endfor %} 153 {%- endfor %}
153 154
154 {{proxy_name}}::{{proxy_name}}(mojo::MessageReceiverWithResponder* receiver) 155 {{proxy_name}}::{{proxy_name}}(mojo::MessageReceiverWithResponder* receiver)
155 : ControlMessageProxy(receiver) { 156 : ControlMessageProxy(receiver) {
156 } 157 }
157 158
158 {#--- Proxy definitions #} 159 {#--- Proxy definitions #}
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 break; 470 break;
470 } 471 }
471 472
472 // Unrecognized message. 473 // Unrecognized message.
473 ReportValidationError( 474 ReportValidationError(
474 &validation_context, 475 &validation_context,
475 mojo::internal::VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD); 476 mojo::internal::VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD);
476 return false; 477 return false;
477 } 478 }
478 {%- endif -%} 479 {%- endif -%}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698