Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002

Committed: https://skia.googlesource.com/skia/+/67cb66648103b4773d1f679cb23f1ebaa6f65e76

[msarett, 2016-06-20 20:11:51]

Description was changed from

==========
Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

BUG=skia:
==========

to

==========
Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002
==========

[msarett, 2016-06-20 20:14:46]

msarett@google.com changed reviewers:
+ djsollen@google.com, mtklein@google.com, scroggo@google.com

[msarett, 2016-06-20 20:14:46]

Some of the clang Android compiler guys are looking for a set of benchmarks to
run while testing compiler optimizations.  I want to give them a set of image
benchmarks to run (but not overwhelm them with our matrix of tests).

FWIW, I actually find this flag useful on its own.  I just haven't bothered to
put it into a CL until now.

[msarett, 2016-06-20 20:41:51]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 20:41:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084683002/1

[commit-bot: I haz the power, 2016-06-20 20:58:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:58:26]

Dry run: This issue passed the CQ dry run.

[scroggo, 2016-06-21 14:52:48]

lgtm

https://codereview.chromium.org/2084683002/diff/1/bench/nanobench.cpp
File bench/nanobench.cpp (right):

https://codereview.chromium.org/2084683002/diff/1/bench/nanobench.cpp#newcode623
bench/nanobench.cpp:623: if (FLAGS_simpleCodec) {
Alternatively, you could always reset fColorTypes to kN32, and then append the
rest 

if (!FLAGS_simpleCodec)

That seems simpler/clearer to me, but maybe you like the existing code better.
The most awkward part to me is that you create an array of one just to copy it.

[msarett, 2016-06-21 15:07:09]

On 2016/06/21 14:52:48, scroggo wrote:
> lgtm
> 
> https://codereview.chromium.org/2084683002/diff/1/bench/nanobench.cpp
> File bench/nanobench.cpp (right):
> 
>
https://codereview.chromium.org/2084683002/diff/1/bench/nanobench.cpp#newcode623
> bench/nanobench.cpp:623: if (FLAGS_simpleCodec) {
> Alternatively, you could always reset fColorTypes to kN32, and then append the
> rest 
> 
> if (!FLAGS_simpleCodec)
> 
> That seems simpler/clearer to me, but maybe you like the existing code better.
> The most awkward part to me is that you create an array of one just to copy
it.

Agreed, I think Patch Set 2 is clearer.

[msarett, 2016-06-21 15:07:22]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 15:07:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084683002/20001

[commit-bot: I haz the power, 2016-06-21 15:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 15:27:48]

Dry run: This issue passed the CQ dry run.

[scroggo, 2016-06-21 15:29:37]

lgtm

[msarett, 2016-06-21 15:48:24]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-06-21 15:48:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2084683002/20001

[commit-bot: I haz the power, 2016-06-21 15:49:29]

Description was changed from

==========
Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002
==========

to

==========
Add --simpleCodec to nanobench flags to run a smaller set of benchmarks

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084683002

Committed:
https://skia.googlesource.com/skia/+/67cb66648103b4773d1f679cb23f1ebaa6f65e76
==========

[commit-bot: I haz the power, 2016-06-21 15:49:30]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/67cb66648103b4773d1f679cb23f1ebaa6f65e76

[Brian Osman, 2016-06-21 16:02:05]

On 2016/06/21 15:49:30, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/67cb66648103b4773d1f679cb23f1ebaa6f65e76

This is causing linker failures on Mac-Clang-Arm7-Debug-iOS.

[msarett, 2016-06-21 16:08:08]

On 2016/06/21 16:02:05, Brian Osman wrote:
> On 2016/06/21 15:49:30, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/67cb66648103b4773d1f679cb23f1ebaa6f65e76
> 
> This is causing linker failures on Mac-Clang-Arm7-Debug-iOS.

I'm on it thanks.