Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: mojo/edk/system/message_pipe_endpoint.cc

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/message_pipe_endpoint.cc
diff --git a/mojo/edk/system/message_pipe_endpoint.cc b/mojo/edk/system/message_pipe_endpoint.cc
index 0211f8695adfe76edfa060eb50b1f6011bbd8725..42da701e92bb2984ac5a874ff624f932e11dea96 100644
--- a/mojo/edk/system/message_pipe_endpoint.cc
+++ b/mojo/edk/system/message_pipe_endpoint.cc
@@ -28,9 +28,9 @@ HandleSignalsState MessagePipeEndpoint::GetHandleSignalsState() const {
}
MojoResult MessagePipeEndpoint::AddAwakable(Awakable* /*awakable*/,
- MojoHandleSignals /*signals*/,
- bool /*force*/,
uint64_t /*context*/,
+ bool /*force*/,
+ MojoHandleSignals /*signals*/,
HandleSignalsState* signals_state) {
NOTREACHED();
if (signals_state)
@@ -38,22 +38,15 @@ MojoResult MessagePipeEndpoint::AddAwakable(Awakable* /*awakable*/,
return MOJO_RESULT_INTERNAL;
}
-void MessagePipeEndpoint::RemoveAwakable(Awakable* /*awakable*/,
+void MessagePipeEndpoint::RemoveAwakable(bool /*match_context*/,
+ Awakable* /*awakable*/,
+ uint64_t /*context*/,
HandleSignalsState* signals_state) {
NOTREACHED();
if (signals_state)
*signals_state = HandleSignalsState();
}
-void MessagePipeEndpoint::RemoveAwakableWithContext(
- Awakable* /*awakable*/,
- uint64_t /*context*/,
- HandleSignalsState* signals_state) {
- NOTREACHED();
- if (signals_state)
- *signals_state = HandleSignalsState();
-}
-
void MessagePipeEndpoint::Attach(ChannelEndpoint* /*channel_endpoint*/) {
NOTREACHED();
}
« no previous file with comments | « mojo/edk/system/message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698