Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: mojo/edk/system/message_pipe_endpoint.cc

Issue 2084593005: Rationalize AddAwakable...() and RemoveAwakable...() methods. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: doh Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/edk/system/message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe_test_utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/edk/system/message_pipe_endpoint.h" 5 #include "mojo/edk/system/message_pipe_endpoint.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace mojo { 9 namespace mojo {
10 namespace system { 10 namespace system {
(...skipping 10 matching lines...) Expand all
21 NOTREACHED(); 21 NOTREACHED();
22 return MOJO_RESULT_INTERNAL; 22 return MOJO_RESULT_INTERNAL;
23 } 23 }
24 24
25 HandleSignalsState MessagePipeEndpoint::GetHandleSignalsState() const { 25 HandleSignalsState MessagePipeEndpoint::GetHandleSignalsState() const {
26 NOTREACHED(); 26 NOTREACHED();
27 return HandleSignalsState(); 27 return HandleSignalsState();
28 } 28 }
29 29
30 MojoResult MessagePipeEndpoint::AddAwakable(Awakable* /*awakable*/, 30 MojoResult MessagePipeEndpoint::AddAwakable(Awakable* /*awakable*/,
31 uint64_t /*context*/,
32 bool /*force*/,
31 MojoHandleSignals /*signals*/, 33 MojoHandleSignals /*signals*/,
32 bool /*force*/,
33 uint64_t /*context*/,
34 HandleSignalsState* signals_state) { 34 HandleSignalsState* signals_state) {
35 NOTREACHED(); 35 NOTREACHED();
36 if (signals_state) 36 if (signals_state)
37 *signals_state = HandleSignalsState(); 37 *signals_state = HandleSignalsState();
38 return MOJO_RESULT_INTERNAL; 38 return MOJO_RESULT_INTERNAL;
39 } 39 }
40 40
41 void MessagePipeEndpoint::RemoveAwakable(Awakable* /*awakable*/, 41 void MessagePipeEndpoint::RemoveAwakable(bool /*match_context*/,
42 Awakable* /*awakable*/,
43 uint64_t /*context*/,
42 HandleSignalsState* signals_state) { 44 HandleSignalsState* signals_state) {
43 NOTREACHED(); 45 NOTREACHED();
44 if (signals_state) 46 if (signals_state)
45 *signals_state = HandleSignalsState(); 47 *signals_state = HandleSignalsState();
46 } 48 }
47 49
48 void MessagePipeEndpoint::RemoveAwakableWithContext(
49 Awakable* /*awakable*/,
50 uint64_t /*context*/,
51 HandleSignalsState* signals_state) {
52 NOTREACHED();
53 if (signals_state)
54 *signals_state = HandleSignalsState();
55 }
56
57 void MessagePipeEndpoint::Attach(ChannelEndpoint* /*channel_endpoint*/) { 50 void MessagePipeEndpoint::Attach(ChannelEndpoint* /*channel_endpoint*/) {
58 NOTREACHED(); 51 NOTREACHED();
59 } 52 }
60 53
61 } // namespace system 54 } // namespace system
62 } // namespace mojo 55 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/edk/system/message_pipe_endpoint.h ('k') | mojo/edk/system/message_pipe_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698